fix: detect Hermes agent mode and restore child SIGINT - #1
Open
seungwonme wants to merge 1 commit into
Open
Conversation
seungwonme
force-pushed
the
fix/hermes-agent-mode-sigint
branch
from
July 5, 2026 03:49
9808ee5 to
4ca1180
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
HERMES_SESSION_ID/HERMES_SESSION_KEYsogethides secret values without extra opt-in.SIGINTdisposition to default before exec, while the wrapper ignores Ctrl-C and waits.Verification
docker run --rm -v /Users/aiden/dev/agents-env:/repo -w /repo rust:1.88-bookworm bash -c 'export PATH=/usr/local/cargo/bin:$PATH; rustup component add clippy >/tmp/rustup-clippy.log; cargo test && cargo clippy --all-targets -- -D warnings'git diff --checkNote
cargo fmt --checkon Rust 1.88 reports formatting diffs in pre-existing untouched files, so this PR keeps the diff focused instead of reformatting the repository.