Skip to content

Enospc aio fix#1947

Draft
lluki wants to merge 2 commits into
ai-dynamo:mainfrom
lluki:enospc-aio-fix
Draft

Enospc aio fix#1947
lluki wants to merge 2 commits into
ai-dynamo:mainfrom
lluki:enospc-aio-fix

Conversation

@lluki

@lluki lluki commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

Follow up PR that fixes AIO like #1942 did for io_uring

@copy-pr-bot

copy-pr-bot Bot commented Jul 15, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@github-actions

Copy link
Copy Markdown

👋 Hi lluki! Thank you for contributing to ai-dynamo/nixl.

Your PR reviewers will review your contribution then trigger the CI to test your changes.

🚀

@svc-nixl

Copy link
Copy Markdown
Collaborator

🤖 CI Triage AgentPR Size Check · commit 5bb9dc4c

TL;DR: The "PR Size Check" gate failed because PR #1947 modifies 979 lines in existing files (excluding subprojects), exceeding the workflow's 500-line hard limit; split the PR into smaller reviewable chunks (or adjust the limit if intentional).

Full analysis

Summary: The check-pr-size job in .github/workflows/pr-size-check.yml exited 1 because the PR exceeds the maximum allowed lines changed.

Root cause: The workflow computes LINES_CHANGED via git show --numstat --pretty="" --diff-filter=M -- . ':(exclude)subprojects/*' and fails when that exceeds 500. For this PR it computed 979 lines (modifications to existing files), so [[ "$LINES_CHANGED" -gt 500 ]] was true and the step ran exit 1. This is an intentional policy gate firing correctly — not a bug or flaky failure. (Log line 12:34:17: "❌ PR size check failed! This PR adds 979 lines (excluding subprojects), which exceeds the maximum of 500 lines.")

Note: the check only counts modified (--diff-filter=M) lines, so this total excludes brand-new files — the modified-file changes alone are already ~2x the limit.

Implicated commit: 5bb9dc4 (the PR head; the merge commit built was b149da2). Not a single "bad" commit — it's the cumulative size of PR #1947 on branch enospc-aio-fix.

File: .github/workflows/pr-size-check.yml (the size-check step); the diff itself is the subject.

Suggested fix: This is a review-policy failure, not a code defect. Preferred fix: split PR #1947 into smaller PRs each under 500 modified lines (e.g. separate the core ENOSPC AIO fix from refactors/tests/docs). If the large size is justified and approved by maintainers, either (a) add a documented bypass label/override to the workflow, or (b) raise the 500-line threshold in pr-size-check.yml — but only with maintainer sign-off, since raising the gate weakens it for all PRs. Do not "fix" this by retrying; it will deterministically fail until the diff shrinks.

Related: none found in logs; check PR #1947's discussion for any size-exception approval.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants