EXAMPLES/DEVICE/EP: Added missing const to Buffer::query_mask_buffer.#1926
Open
rakhmets wants to merge 1 commit into
Open
EXAMPLES/DEVICE/EP: Added missing const to Buffer::query_mask_buffer.#1926rakhmets wants to merge 1 commit into
rakhmets wants to merge 1 commit into
Conversation
Signed-off-by: Raul Akhmetshin <rakhmetshin@nvidia.com>
Contributor
📝 WalkthroughWalkthrough
ChangesQuery mask buffer const correctness
Estimated code review effort: 2 (Simple) | ~10 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Contributor
Author
|
/build |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Added missing
constto the declaration ofBuffer::query_mask_buffer.Added missing
constto a parameter ofep_kernels::query_mask_buffer.Why?
To improve the readability of the code, following C++ core guidelines.
Spotted by the PR (#1793), need to reduce the size of the PR, removing unrelated changes.