Skip to content

GREP-617 Topology Binding Policy#620

Open
enoodle wants to merge 2 commits into
ai-dynamo:mainfrom
enoodle:erez/scheduler-backend-topology-binding-policy-GREP
Open

GREP-617 Topology Binding Policy#620
enoodle wants to merge 2 commits into
ai-dynamo:mainfrom
enoodle:erez/scheduler-backend-topology-binding-policy-GREP

Conversation

@enoodle

@enoodle enoodle commented May 18, 2026

Copy link
Copy Markdown
Contributor

What type of PR is this?

/kind api
/kind documentation

What this PR does / why we need it:

GREP for #617 - Adding configurable policy for Topology CR creation per scheduling backend.

Which issue(s) this PR fixes:

References #617

Special notes for your reviewer:

Does this PR introduce a API change?

NONE - this is a GREP only

Additional documentation e.g., enhancement proposals, usage docs, etc.:

@copy-pr-bot

copy-pr-bot Bot commented May 18, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@enoodle enoodle changed the title feat: topology binding policy GREP GREP-617 topology binding policy May 18, 2026
@enoodle enoodle changed the title GREP-617 topology binding policy GREP-617 Topology Binding Policy May 18, 2026
@xianlubird

Copy link
Copy Markdown
Contributor

I could not agree more. This proposal looks very similar to the schedulerTopologyReferences section described in the topology-aware scheduling GREP: https://github.com/ai-dynamo/grove/tree/main/docs/proposals/244-topology-aware-scheduling.

I think this can greatly simplify scheduler backend implementations. In practice, topology-aware scheduling often involves multiple backend-specific resources, and managing those resources correctly can become quite complex.

That said, I think Grove should still support both modes. Some users may prefer to manage the scheduler backend topology resources explicitly, while others may prefer Grove to derive and manage them automatically from ClusterTopology. Having a per-backend policy such as AutoCreate vs ReferenceRequired sounds like a good way to make that behavior explicit.

xianlubird

This comment was marked as outdated.

Comment thread docs/proposals/0617-scheduler-backend-topology-binding-policy/README.md Outdated
@enoodle enoodle force-pushed the erez/scheduler-backend-topology-binding-policy-GREP branch from 9979de6 to 8805548 Compare May 19, 2026 11:22

@xianlubird xianlubird left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -0,0 +1,155 @@
# GREP-0617: Scheduler Backend Topology Binding Policy

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: existing GREP directories use the un-padded issue number as the prefix (e.g. 244-, 375-, 436-). Could we rename this to 617-scheduler-backend-topology-binding-policy/ and update the heading to GREP-617 to stay consistent? Thanks!

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comes from the GREP skill in the repo: https://github.com/ai-dynamo/grove/blob/main/.agents/skills/grove-grep/SKILL.md#step-1--identify-the-grep
so it should be updated there first. currently it is the "new standard" here :)

enoodle added 2 commits May 21, 2026 10:43
Signed-off-by: Erez Freiberger <enoodle@gmail.com>
Signed-off-by: Erez Freiberger <enoodle@gmail.com>
@enoodle enoodle force-pushed the erez/scheduler-backend-topology-binding-policy-GREP branch from 8805548 to 9acdf5a Compare May 21, 2026 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants