fix: accept PEP 440 suffixes when determining next RC#9814
Merged
saturley-hall merged 1 commit intoMay 21, 2026
Conversation
The "Determine next RC number" step in the release workflow rejected `pyproject.toml` versions like `1.2.0.post1` against a strict three-segment regex, breaking every workflow_dispatch on release/1.2.0 after the post1 bump. Broaden the base-version regex to also accept .postN / .devN / aN / bN / rcN suffixes, and convert each to a dotted-SemVer pre-release identifier when assembling the Helm chart version and NGC image tag so both stay valid SemVer (e.g. `1.2.0.post1` -> `1.2.0-post.1-rc.0`). Plain X.Y.Z keeps the existing tag shape unchanged. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "Determine next RC number" step in the release workflow rejected
pyproject.tomlversions like1.2.0.post1against a strict three-segment regex, breaking every workflow_dispatch on release/1.2.0 after the post1 bump.Broaden the base-version regex to also accept .postN / .devN / aN / bN / rcN suffixes, and convert each to a dotted-SemVer pre-release identifier when assembling the Helm chart version and NGC image tag so both stay valid SemVer (e.g.
1.2.0.post1->1.2.0-post.1-rc.0). Plain X.Y.Z keeps the existing tag shape unchanged.Closes OPS-5418