fix: update support matrix [main]#1366
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
📜 Recent review details⏰ Context from checks skipped due to timeout. (7)
🧰 Additional context used📓 Path-based instructions (5)tests/**/*.{py,yaml,txt,sh}📄 CodeRabbit inference engine (.claude/rules/generator/testing.md)
Files:
**/*📄 CodeRabbit inference engine (.claude/rules/repo-guide.md)
Files:
⚙️ CodeRabbit configuration file
Files:
**/*.{py,pyi}📄 CodeRabbit inference engine (AGENTS.md)
Files:
tests/**/*.py📄 CodeRabbit inference engine (AGENTS.md)
Files:
tests/**⚙️ CodeRabbit configuration file
Files:
🔇 Additional comments (1)
WalkthroughAdds a YAML collection plan for ChangesModel collection and support expectations
Estimated code review effort: 1 (Trivial) | ~2 minutes Poem
🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
Comment |
Full local regeneration of the support matrix on main (2feebac) using the CI docker image (docker/Dockerfile --target test), 16 workers. 10502 configurations across 5251 model/system/backend/version combos. Rebased onto main after ai-dynamo#1322 relocated the matrix to aic-core/src/aiconfigurator_core/systems/support_matrix/. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Signed-off-by: tianhaox <tianhaox@nvidia.com>
f868838 to
dfadb26
Compare
The support matrix now contains MiniMaxAI/MiniMax-M3 rows (SDK support landed in ai-dynamo#1238), but no collector case file existed for the MiniMaxM3ForCausalLM architecture, failing test_support_matrix_models_have_model_case_aliases. Register the model with base-op coverage only; the MSA attention op is not authored yet. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Signed-off-by: tianhaox <tianhaox@nvidia.com>
|
Unit-test fix: the regenerated matrix now contains |
sglang 0.5.9 and trtllm 1.3.0rc10 rows changed to PASS (Source=silicon) in the regenerated matrix via shared-layer reuse of newly collected sibling-version data, so check_support now returns True for them. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Signed-off-by: tianhaox <tianhaox@nvidia.com>
Generated by a full local run of
tools/support_matrix/generate_support_matrix.pyonmain@ 2feebac, using the CI docker image (docker/Dockerfile --target test), 16 worker processes, ~22.5h wall clock. 10502 configurations tested across 5251 model/system/backend/version combinations (106 database groups), including the recently added sglang 0.5.14 / vllm 0.24.0 data that the in-repo matrix predates.This PR updates the split support matrix CSV files with the following changes:
Summary
1. Silicon regressions (PASS -> non-PASS): 101 rows
2. Hybrid regressions (HYBRID_PASS -> non-pass): 0 rows
No hybrid regressions
3. Silicon fixes (non-PASS -> PASS): 437 rows
(diff tables truncated to fit the PR body limit; full
diff.jsonavailable on request)🤖 Generated with Claude Code
Summary by CodeRabbit
zai-org/GLM-5-FP8for specificsglangand TensorRT-LLM versions.