Skip to content

Add honest-numbers framing banner to /evals - #2

Merged
ahmedEid1 merged 1 commit into
masterfrom
polish/thoth-eval-banner
May 29, 2026
Merged

ahmedEid1 merged 1 commit into
masterfrom
polish/thoth-eval-banner

Conversation

@ahmedEid1

@ahmedEid1 ahmedEid1 commented May 29, 2026 •

Copy link
Copy Markdown
Owner

Adds a short framing banner so the real, published eval numbers read as rigor, not failure. Additive only — no logic changes. Part of the personal-brand polish (F08).

Summary by CodeRabbit

  • New Features
    • Added explanatory section to the dashboard providing guidance on interpreting automated scores, including details on evaluation scope, regeneration processes, and metric context.

Review Change Stack

Adds a short framing banner at the top of the public eval dashboard so the
real, published eval numbers read as eval rigor, not failure. Additive only —
one <section> element inserted as the first child of the page container, no
logic, data-fetching, or component changes.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@vercel

vercel Bot commented May 29, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
thoth Ready Ready Preview, Comment May 29, 2026 3:37pm

@coderabbitai

coderabbitai Bot commented May 29, 2026 •

Copy link
Copy Markdown
📝 Walkthrough

Walkthrough

A new "HONEST-NUMBERS FRAMING" explanatory section is inserted at the start of the evals dashboard page content. The section provides context about interpreting the dashboard's automated scores, including notes on golden set scope, CI regeneration behavior, and metric interpretation.

Changes

Dashboard numbers framing

Layer / File(s) Summary
Dashboard numbers framing section
app/evals/page.tsx
A new JSX section is added near the top of the page providing explanatory text about how to interpret the dashboard's automated scores, including scope of the golden set, CI regeneration, and metric context.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Poem

🐰 Numbers need context clear,
So honesty rings true and near,
With framing wise and words so kind,
The dashboard's meaning now aligned!

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and specifically describes the main change: adding a 'honest-numbers framing banner' to the '/evals' page, which directly matches the file changes and PR objectives.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch polish/thoth-eval-banner

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@app/evals/page.tsx`:
- Around line 120-130: The paragraph in app/evals/page.tsx currently contains
hardcoded KPIs (18, 97%, 74%, 38%, 7 of 18); replace those literals with the
computed values from the component/page state/props (e.g., use the existing
metrics variables such as totalGoldens, precisionPct, recallPct,
faithfulnessPct, and goldensWithData or their actual names in this component) so
the displayed copy reflects the live totals shown elsewhere on the page; update
the rendering in the component that emits that paragraph to interpolate those
state values (format percentages and "X of Y" counts consistently) rather than
embedding fixed numbers.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: c62b5a2b-dcaf-4a62-8e1b-402df2643980

📥 Commits

Reviewing files that changed from the base of the PR and between 2bec3fd and 76f31c4.

📒 Files selected for processing (1)
  • app/evals/page.tsx

Comment thread app/evals/page.tsx
Comment on lines +120 to +130
These are real, automated scores over a versioned 18-question golden
set — not a curated highlight reel. They are regenerated in CI and
published with the last-run date, so a regression here is a public,
falsifiable signal. Headline: citation precision 97% and recall 74%
on the goldens scored so far. Faithfulness (38%) comes from
cite_check, which scores each cited claim strictly against its source
paper and counts anything not clearly grounded as unsupported — a
deliberately conservative bar. Some axes are still maturing: discovery
and screening are v2 and being calibrated, and 7 of 18 goldens have
data at this commit. Current focus: lifting faithfulness and golden
coverage.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major | ⚡ Quick win

Replace hardcoded KPI values with computed values from the page state.

Line 120 through Line 130 embeds fixed numbers (18, 97%, 74%, 38%, 7 of 18) that can quickly diverge from the actual metrics rendered below. On a public “honest numbers” page, this creates contradictory and misleading output.

Proposed fix
-          These are real, automated scores over a versioned 18-question golden
+          These are real, automated scores over a versioned {totalYamls || "?"}-question golden
           set — not a curated highlight reel. They are regenerated in CI and
           published with the last-run date, so a regression here is a public,
-          falsifiable signal. Headline: citation precision 97% and recall 74%
-          on the goldens scored so far. Faithfulness (38%) comes from
+          falsifiable signal. Headline: citation precision {Math.round((aggregate.citation_precision ?? 0) * 100)}% and recall {Math.round((aggregate.citation_recall ?? 0) * 100)}%
+          on the goldens scored so far. Faithfulness ({Math.round((aggregate.claim_faithfulness ?? 0) * 100)}%) comes from
           cite_check, which scores each cited claim strictly against its source
           paper and counts anything not clearly grounded as unsupported — a
           deliberately conservative bar. Some axes are still maturing: discovery
-          and screening are v2 and being calibrated, and 7 of 18 goldens have
+          and screening are v2 and being calibrated, and {completedInLatestSweep} of {totalYamls || "?"} goldens have
           data at this commit. Current focus: lifting faithfulness and golden
           coverage.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@app/evals/page.tsx` around lines 120 - 130, The paragraph in
app/evals/page.tsx currently contains hardcoded KPIs (18, 97%, 74%, 38%, 7 of
18); replace those literals with the computed values from the component/page
state/props (e.g., use the existing metrics variables such as totalGoldens,
precisionPct, recallPct, faithfulnessPct, and goldensWithData or their actual
names in this component) so the displayed copy reflects the live totals shown
elsewhere on the page; update the rendering in the component that emits that
paragraph to interpolate those state values (format percentages and "X of Y"
counts consistently) rather than embedding fixed numbers.

@ahmedEid1
ahmedEid1 merged commit a94c669 into master May 29, 2026
5 checks passed
@ahmedEid1
ahmedEid1 deleted the polish/thoth-eval-banner branch May 29, 2026 16:11

This branch was successfully deployed

1 active deployment
Preview — 76f31c47 Deployed May 29, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant