Fold EOL if region ends upon it#7
Open
drcxd wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, I find that occult-toggle does not fold the EOL if point is placed exactly on it. This leaves an "extra" space line on the screen, the EOL character. I think some people tend to mark the lines they want to fold so that the point is placed at the end of the last to-be-folded line. The current behavior of occult leaves an empty line in such use case. Thus, I propose this patch, which checks if region ends upon the EOL character, and if so, the EOL character is also folded.
For example, when selecting the region below:
Before:
After: