fix: safely serialize webview initialization data - #699
Merged
agrawal-d merged 2 commits intoAug 3, 2026
Conversation
Encode settings and other dynamic values before embedding them in the webview's inline script, preserving Windows paths and preventing script termination.
Add regression coverage for Windows command paths and values that could alter or terminate an inline script.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When config paths contain
\u(e.g. \uv) on Windows, a SyntaxError will be thrown because webview script will tries to parse\uas a unicode escape.So I fixed it by using
JSON.stringifyinstead of injecting raw settings strings into scripts.Also added tests for Windows path escaping.
Acknowledge