Fix: detect script injection API before calling it (CPH Submit error) - #38
Merged
agrawal-d merged 2 commits intoApr 30, 2026
Conversation
There was a problem hiding this comment.
Pull request overview
This PR prevents a runtime failure during submission by guarding against environments where browser.tabs.executeScript is present as an object but not available as a callable function (e.g., Manifest V3), ensuring the code falls back to chrome.scripting.executeScript instead.
Changes:
- Added a function-availability check for
browser.tabs.executeScriptbefore attempting MV2-style script injection. - Ensures MV3 injection via
chrome.scripting.executeScriptis used whenbrowser.tabs.executeScriptis unavailable.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Owner
|
Thanks! |
Contributor
Author
|
Thanks for merging my PR, @agrawal-d. Missed formatting the code, my bad... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes a runtime error when submitting with CPH Submit:
TypeError: browser.tabs.executeScript is not a functionThe submission page opened, but script injection failed, so the submission didn’t complete.
Root Cause
browser.tabs.executeScriptisn’t available in all environments (e.g., Manifest V3), causing a runtime error.Fix
chrome.scripting.executeScriptwhen availablebrowser.tabs.executeScriptotherwiseChanges
handleSubmit.tsTesting
Closes #37