Repository navigation
cleanup: remove PlayerTracking from the Rust SDK - #4768
Merged
markmandel merged 2 commits intoOct 8, 2026
Merged
Conversation
github-actions
Bot
added
kind/cleanup
Remove the PlayerTracking methods from the Rust SDK while keeping the Alpha client as a stub for future alpha features, following the same approach as the Python and Node.js SDK removals. - Remove the seven player-tracking methods (get_player_capacity, set_player_capacity, player_connect, player_disconnect, get_player_count, is_player_connected, get_connected_players) from src/alpha.rs, leaving the gRPC client stub in place. - Replace the player tracking unit tests (a hand-rolled MockAlpha and its lifecycle test) with a stub test that verifies the Alpha client's gRPC channel is constructed. - Remove the player tracking steps (and their now-unused functions) from the Rust SDK conformance test client, for both the sync and async code paths. Work on agones-dev#4491 Signed-off-by: Mark Mandel <mark@compoundtheory.com>
markmandel
force-pushed
the
remove-player-tracking-rust
branch
from
October 5, 2026 02:41
8ebb989 to
41e860f
Compare
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The focused cleanup consistently removes the deprecated Rust APIs and their test usages.
Review effort: Balanced
Findings: None
What changed in this PR
Removes deprecated PlayerTracking APIs from the Rust SDK while retaining the Alpha client stub.
Changes:
- Removes seven Alpha PlayerTracking methods and related tests.
- Removes synchronous and asynchronous conformance-test flows.
- Adds a construction test for the retained Alpha client.
| File | Description |
|---|---|
sdks/rust/src/alpha.rs |
Retains an Alpha stub without PlayerTracking methods. |
test/sdk/rust/src/main.rs |
Removes PlayerTracking conformance paths. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Collaborator
|
Build Succeeded 🥳 Build Id: 3c2c64a7-9431-4eb0-b34e-171e806e09c5 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version: |
lacroixthomas
approved these changes
Oct 8, 2026
markmandel
enabled auto-merge (squash)
October 8, 2026 22:00
Collaborator
|
Build Succeeded 🥳 Build Id: b66095dd-146a-446a-ba74-80e30c77efa0 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / Why we need it:
Remove the PlayerTracking methods from the Rust SDK while keeping the Alpha client as a stub for future alpha features, following the same approach as the Python and Node.js SDK removals.
Which issue(s) this PR fixes:
Work on #4491
Did you use AI tools in preparing this PR?:
Y
Special notes for your reviewer:
N/A