Skip to content

fix(harness): preserve non-UTF-8 file uploads - #2456

Open
wangxuefen88 wants to merge 1 commit into
agentscope-ai:mainfrom
wangxuefen88:fix/2447-binary-upload
Open

fix(harness): preserve non-UTF-8 file uploads#2456
wangxuefen88 wants to merge 1 commit into
agentscope-ai:mainfrom
wangxuefen88:fix/2447-binary-upload

Conversation

@wangxuefen88

Copy link
Copy Markdown

Summary

  • decode uploaded content using strict UTF-8 error reporting
  • fall back to Base64 when uploaded bytes are not valid UTF-8
  • add a binary upload/download round-trip regression test

Testing

  • mvn -q -pl agentscope-harness -am test
  • mvn -q -pl agentscope-harness -am spotless:check

Fixes #2447

@gemini-code-assist

Copy link
Copy Markdown

Caution

The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased.

@codecov

codecov Bot commented Jul 28, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]:RemoteFilesystem.uploadFiles corrupts non-UTF-8 binary content

2 participants