Repository navigation
Name app_connect as the permission connect_app requires - #68
Closed
sidharth0612 wants to merge 1 commit into
Closed
sidharth0612 wants to merge 1 commit into
sidharth0612 wants to merge 1 commit into
Conversation
Phase 2 of the provider -> app rename renames the API-key permission provider_connect to app_connect (plans/specs/provider-to-app-rename-phase-2-permissions.md in agentmail-api). connect_app's description now says it requires the app_connect permission, matching the API's error text and the console's "App: Connect" label once those ship. Nothing in the toolkit reads permissions from SDK responses, so this is the only change. 0.10.1, so the MCP server can pin a release that carries the new description. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Oct 1, 2026
Closed
Contributor
Author
|
Dependency links (opened after this PR): agentmail-api phase 2 PR 2a is agentmail-to/agentmail-api#1515 (stacked on #1512), writer flip 2b is #1516. This merges only after #1515 is live in prod. |
Contributor
Author
sidharth0612
marked this pull request as ready for review
October 1, 2026 23:10
sidharth0612
added a commit
that referenced
this pull request
Oct 1, 2026
Folded from #68 so the rename ships as one 0.10.0 release. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Author
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Phase 2 of the provider → app rename renames the API-key permission
provider_connecttoapp_connect.connect_app's description now ends "Requires the app_connect permission." That is the toolkit's only mention of a permission name.node/src/tools.ts:connect_app's description namesapp_connect. No other wording changes.node/package.json: 0.10.0 → 0.10.1, so agentmail-mcp can pin a release that carries the new description. See the version note under Release order.node/orpython/readspermissionsfrom SDK responses, and nothing namesproviderConnect,providerShareOwnerorprovider_share_owner. So the new SDK droppingproviderConnect/providerShareOwnerfromApiKeyPermissionsneeds no code change here.Dependencies (why this is a draft)
claude/app-rename-toolkit, and GitHub retargets this PR tomainwhen Rename the provider tools to list_apps, search_apps, get_app, connect_app #67 merges.plans/specs/provider-to-app-rename-phase-2-permissions.md). Until then, the API's 403fixtext and the console still call the permissionprovider_connect/ "Provider: Connect". This description would name a permission the user can't find.npx tsc --noEmitshows the same 9 errors as Rename the provider tools to list_apps, search_apps, get_app, connect_app #67: the fiveclient.appsaccesses and the 4 that are already onmain. This PR adds none, and it needs no new SDK field because it reads no permissions.Before marking ready
Checks run (
node/)pnpm lint: clean.pnpm build(tsup, with dts): passes.pnpm test: 465/465.npx tsc --noEmit: 9 errors, the same as on Rename the provider tools to list_apps, search_apps, get_app, connect_app #67 (above).Release order
Phase 2 of the provider → app rename: the API-key permissions. The spec is
plans/specs/provider-to-app-rename-phase-2-permissions.mdin agentmail-api. Phase 1 isplans/specs/provider-to-app-rename-phase-1.md.app_connect/app_share_ownerbeside the old names, returns both names, and its errorfixtext names onlyapp_connect.agentmail-toolkit0.10.1.mcp-manifest.json, then deploy the connector.backend-contract.jsonagainst agentmail-mcpmain) and Re-export the skills with app_connect and release 0.5.1 agentmail-plugins#17 (re-export from AddDraftTools #19, release 0.5.1).The console relabel to "App: Connect" (agentmail-web
apps/console/app/lib/permissions-config.ts, a separate phase 2 follow-up) should be live by step 4. The skill tells the user to enableapp_connecton the key in the console.Versions: 0.10.1 and 0.5.1 assume phase 1 publishes 0.10.0 and 0.5.0 on its own first. If both phases release together, publish the toolkit as 0.10.1 (skipping 0.10.0). For plugins, fold the 0.5.1 entry into 0.5.0, drop its "keeps its name" line, and stay on 0.5.0.
🤖 Generated with Claude Code