Skip to content

Name app_connect as the permission connect_app requires - #68

Closed
sidharth0612 wants to merge 1 commit into
claude/app-rename-toolkitfrom
claude/app-rename-toolkit-permissions
Closed

sidharth0612 wants to merge 1 commit into
claude/app-rename-toolkitfrom
claude/app-rename-toolkit-permissions

Conversation

@sidharth0612

@sidharth0612 sidharth0612 commented Oct 1, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Phase 2 of the provider → app rename renames the API-key permission provider_connect to app_connect. connect_app's description now ends "Requires the app_connect permission." That is the toolkit's only mention of a permission name.

  • node/src/tools.ts: connect_app's description names app_connect. No other wording changes.
  • node/package.json: 0.10.0 → 0.10.1, so agentmail-mcp can pin a release that carries the new description. See the version note under Release order.
  • No permission reads. Nothing in node/ or python/ reads permissions from SDK responses, and nothing names providerConnect, providerShareOwner or provider_share_owner. So the new SDK dropping providerConnect / providerShareOwner from ApiKeyPermissions needs no code change here.
  • The Python toolkit has no AgentID tools, so nothing changes there.

Dependencies (why this is a draft)

Before marking ready

Checks run (node/)

Release order

Phase 2 of the provider → app rename: the API-key permissions. The spec is plans/specs/provider-to-app-rename-phase-2-permissions.md in agentmail-api. Phase 1 is plans/specs/provider-to-app-rename-phase-1.md.

  1. agentmail-api phase 2 PR 2a (not open yet, stacked on agentmail-to/agentmail-api#1512) is live in prod. It accepts app_connect / app_share_owner beside the old names, returns both names, and its error fix text names only app_connect.
  2. Phase 1 tooling releases first, or together with this set: Rename the provider tools to list_apps, search_apps, get_app, connect_app #67, Serve the app tools from agentmail-toolkit 0.10.0 agentmail-mcp#63, Rename AgentID providers to apps in the skills agentmail-skills#18 and Re-export the skills with AgentID apps and release 0.5.0 agentmail-plugins#16. Each phase 2 PR is stacked on its phase 1 PR.
  3. Toolkit: Name app_connect as the permission connect_app requires #68. Publish agentmail-toolkit 0.10.1.
  4. MCP: Serve connect_app naming app_connect from agentmail-toolkit 0.10.1 agentmail-mcp#64. Pin the published 0.10.1, regenerate the lockfile and mcp-manifest.json, then deploy the connector.
  5. Skills and plugins, together: Name app_connect in the AgentID skill's 403 guidance agentmail-skills#19 (re-sync backend-contract.json against agentmail-mcp main) and Re-export the skills with app_connect and release 0.5.1 agentmail-plugins#17 (re-export from AddDraftTools #19, release 0.5.1).

The console relabel to "App: Connect" (agentmail-web apps/console/app/lib/permissions-config.ts, a separate phase 2 follow-up) should be live by step 4. The skill tells the user to enable app_connect on the key in the console.

Versions: 0.10.1 and 0.5.1 assume phase 1 publishes 0.10.0 and 0.5.0 on its own first. If both phases release together, publish the toolkit as 0.10.1 (skipping 0.10.0). For plugins, fold the 0.5.1 entry into 0.5.0, drop its "keeps its name" line, and stay on 0.5.0.

🤖 Generated with Claude Code

Phase 2 of the provider -> app rename renames the API-key permission
provider_connect to app_connect
(plans/specs/provider-to-app-rename-phase-2-permissions.md in
agentmail-api). connect_app's description now says it requires the
app_connect permission, matching the API's error text and the console's
"App: Connect" label once those ship.

Nothing in the toolkit reads permissions from SDK responses, so this is
the only change. 0.10.1, so the MCP server can pin a release that
carries the new description.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@sidharth0612

Copy link
Copy Markdown
Contributor Author

Dependency links (opened after this PR): agentmail-api phase 2 PR 2a is agentmail-to/agentmail-api#1515 (stacked on #1512), writer flip 2b is #1516. This merges only after #1515 is live in prod.

@sidharth0612

Copy link
Copy Markdown
Contributor Author

Gate met: agentmail-api #1515 is in prod everywhere, and SDK 0.5.34 (appConnect/appShareOwner) is published; the toolkit reads no permission fields, so only the description text changes here. Merge after #67 and publish them together as 0.10.1 (or fold into 0.10.0 if #67 hasn't been published yet).

@sidharth0612
sidharth0612 marked this pull request as ready for review October 1, 2026 23:10
sidharth0612 added a commit that referenced this pull request Oct 1, 2026
Folded from #68 so the rename ships as one 0.10.0 release.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@sidharth0612

Copy link
Copy Markdown
Contributor Author

Folded into #67 (commit b98435a) so the rename ships as one release, 0.10.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant