fix(charts): ingress ssl policy - #1720
Open
omrishiv wants to merge 2 commits into
Open
Conversation
Add optional global.ingress.sslPolicy that renders alb.ingress.kubernetes.io/ssl-policy on the registry ingress, following the same pattern as inboundCidrs. Leaving it unset preserves the AWS Load Balancer Controller default (ELBSecurityPolicy-2016-08); operators can set a modern policy (e.g. ELBSecurityPolicy-TLS-1-2-Ext-2018-06) to avoid TLS handshake failures with clients requiring newer TLS. Closes agentic-community#1661
…alues Add documented (empty) global.ingress.inboundCidrs and global.ingress.sslPolicy keys to the registry subchart values so the knobs are discoverable for standalone (non-umbrella) deploys. Empty defaults are falsy and leave both annotations omitted.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Closes: #1661
Description of changes:
Adds an overrideable field to change the default ssl policy for the registry ingress
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.