feat(egress): add operator_credential mode to inject the shared backend credential - #1686
Open
doppelc wants to merge 2 commits into
Open
feat(egress): add operator_credential mode to inject the shared backend credential#1686doppelc wants to merge 2 commits into
doppelc wants to merge 2 commits into
Conversation
|
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If you register an MCP server that uses a static bearer token or API key (Backend Authentication), health checks pass, but user tool calls don't. The proxy hop strips the caller's gateway auth and injects nothing.
This was reported in #1598, where the patch was declined in favor of an explicit egress mode. This PR builds that mode. Credit to @hochbit for the original patch and for surfacing the gap.
This PR adds one new egress mode:
operator_credential. An admin sets it on a server, and from then on the gateway injects that server's stored Backend Authentication credential for every caller it authorizes. It works with bothbearerandapi_keyschemes and reuses the configured header name, exactly like PAT mode.It's strictly opt-in:
auth_scheme=beareralone changes nothing, an admin has to set the mode per server, and the deployment needsEGRESS_AUTH_ENABLED=true. Clients never see the credential. Connect configs stop emitting the server-auth placeholder.