ateapi: fail cleanly on a malformed actor JWT signing pool - #601
Open
Mesut Oezdil (mesutoezdil) wants to merge 2 commits into
Open
ateapi: fail cleanly on a malformed actor JWT signing pool#601Mesut Oezdil (mesutoezdil) wants to merge 2 commits into
Mesut Oezdil (mesutoezdil) wants to merge 2 commits into
Conversation
MintJWT reads the signing pool file on every call and indexes Authorities[0] directly. localjwtauthority.Unmarshal reports no error for JSON that carries no authorities, so an empty or incompletely written pool file reaches that index and panics. sessionidjwt.Sign then type-asserts the signing key without checking, so a pool entry whose algorithm does not match its key type panics as well. Neither is recoverable: nothing in the server installs a panic-recovery interceptor, so a configuration error in the pool file takes down ate-api-server on the first MintJWT call rather than returning an error to the caller. Check the pool for authorities before selecting one, and check each key type assertion in Sign. MintCert already guards an empty session CA pool the same way; this brings the JWT path in line with it. The signing-authority selection moves into a helper so it can be tested without standing up an OIDC issuer to satisfy the client-JWT verification that precedes it. Both packages had no tests; the ones added here also pin the existing behavior of the working paths.
…panics # Conflicts: # cmd/ateapi/internal/actoridentity/actoridentity.go # cmd/ateapi/internal/actoridentity/sessionidentity_test.go # cmd/ateapi/internal/actoridjwt/sessionidjwt_test.go
Mesut Oezdil (mesutoezdil)
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MintJWTindexesAuthorities[0]from the actor JWT signing pool file, andactoridjwt.Signtype-asserts the signing key without checking it, so a pool file carrying no authorities (whichlocaljwtauthority.Unmarshalaccepts without error) or an algorithm that does not match its key panics instead of returning an error. Nothing in the server installs a panic-recovery interceptor, so that configuration error takes down ate-api-server on the firstMintJWTcall, andMintCertalready guards the same situation for its own pool. This adds the missing checks plus the first tests for both packages, which also pin the behavior of the paths that already worked.