feat: extend edge routing telemetry with resume and outcome labels - #591
Open
Angela (Angelawork) wants to merge 5 commits into
Open
feat: extend edge routing telemetry with resume and outcome labels#591Angela (Angelawork) wants to merge 5 commits into
Angela (Angelawork) wants to merge 5 commits into
Conversation
Angela (Angelawork)
force-pushed
the
feature/router-telemetry
branch
2 times, most recently
from
July 29, 2026 18:02
4c0eb73 to
67c0e93
Compare
Jeff Luo (JeffLuoo)
requested changes
Jul 30, 2026
Angela (Angelawork)
force-pushed
the
feature/router-telemetry
branch
from
July 30, 2026 06:27
67c0e93 to
bbdca77
Compare
Collaborator
|
Overall it LGTM, but since this change touches Julian Gutierrez Oschmann (@juli4n) Max Smythe (@maxsmythe) Zoe Zhao (@zoez7) |
Angela (Angelawork)
force-pushed
the
feature/router-telemetry
branch
2 times, most recently
from
July 30, 2026 15:27
ff4839b to
c955d56
Compare
Jeff Luo (JeffLuoo)
previously approved these changes
Jul 30, 2026
Jeff Luo (JeffLuoo)
left a comment
Jeff Luo (JeffLuoo)
left a comment
Collaborator
There was a problem hiding this comment.
Please rebase
Angela (Angelawork)
force-pushed
the
feature/router-telemetry
branch
from
July 30, 2026 18:37
c955d56 to
3497427
Compare
Collaborator
Author
Done! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #564 (Part 1)
Description
This PR implements the first part of #564 by extending metric
atenet.router.route.durationwith singleflight activation state (ate.router.resume) and outcome status labels (ate.router.outcome). All telemetry attribute keys and label value sets are centralized ininternal/ateattrto ensure consistency across components.Key Changes:
resumedboolean toResumeActorResponseinateapi.protoindicating whether a cold activation workflow occurred (!state.WasRunning).workflow_resume_test.goto assertresumed == trueon cold activations andresumed == falsefor already-running actors.classifyOutcome(err)in Envoyext_procto classify errors into metric labels:ok,cancelled,timeout,no_capacity,lock_conflict,not_found,unavailable,rate_limited, andresume_error.codes.Unavailable("unavailable") andcodes.ResourceExhausted/StatusCode_TooManyRequests("rate_limited").atenet.router.route.durationusing standard keys frominternal/ateattr:ate.template.namespace(TemplateNamespaceKey)ate.template.name(TemplateNameKey)ate.router.outcome(RouterOutcomeKey)ate.router.resume(RouterResumeKey)manifests/ate-install/kind/kustomization.yamlto exportatenet-routerOTLP metrics toopentelemetry-collector.Testing
go test -buildvcs=false ./cmd/ateapi/internal/controlapi/...go test -buildvcs=false ./cmd/atenet/internal/router/...make testE2E Test
./hack/create-kind-cluster.sh./hack/install-ate-kind.sh --deploy-ate-system --deploy-demo-counter./hack/run-e2e.sh ./internal/e2e/suites/metrics/...