ateapi/controlapi: retry worker updates on version conflict in syncer - #578
Open
Troy Chiu (troychiu) wants to merge 1 commit into
Open
ateapi/controlapi: retry worker updates on version conflict in syncer#578Troy Chiu (troychiu) wants to merge 1 commit into
Troy Chiu (troychiu) wants to merge 1 commit into
Conversation
| slog.InfoContext(ctx, "Syncer: updating worker in store (labels changed)", slog.String("worker", pod.Namespace+"/"+pod.Name)) | ||
| w.Labels = pool.GetLabels() | ||
| changed = true | ||
| // TODO: We perform an inline retry loop here using wait.ExponentialBackoff |
Collaborator
There was a problem hiding this comment.
Should we just make that change now? How large would it be? IIRc The ActorTemplate controller already uses requeue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds retry logic with exponential backoff when
WorkerPoolSyncerencounters optimistic locking conflicts (store.ErrVersionConflict) while updating worker state in the store.Before:
syncWorkerToStoreattempted a singleUpdateWorkerwrite. If a concurrent write modified the worker in Redis, it failed withstore.ErrVersionConflict, logged an error, and silently dropped the metadata update (SandboxClass,Labels).Now: On
store.ErrVersionConflict,WorkerPoolSyncerretries up to 5 times with exponential backoff, re-fetching the latest worker state from Redis on each attempt before re-applying changes.Tests pass
Appropriate changes to documentation are included in the PR