Skip to content

Fix the issue that run-e2e.sh doesn't work on bash 3.2 macos. #571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Julian Gutierrez Oschmann (juli4n) merged 1 commit into from
Jul 29, 2026
+6 −3
Merged

Fix the issue that run-e2e.sh doesn't work on bash 3.2 macos. #571

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion hack/run-e2e.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,5 +103,5 @@ if [[ -n "${KUBECTL_CONTEXT:-}" ]]; then
extra_e2e_args+=("--kube-context" "${KUBECTL_CONTEXT}")
fi

exec go test -v "$target_path" "${go_test_args[@]}" -args --e2e "${extra_e2e_args[@]}" "${e2e_args[@]}"
exec go test -v "$target_path" ${go_test_args[@]+"${go_test_args[@]}"} -args --e2e ${extra_e2e_args[@]+"${extra_e2e_args[@]}"} ${e2e_args[@]+"${e2e_args[@]}"}

7 changes: 5 additions & 2 deletions hack/verify/python-licenses.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,10 @@ cd "${ROOT}"
# that contains requirements.txt; its venv lives at <dir>/venv. Discovered
# dynamically from tracked/untracked (but not ignored) requirements.txt files,
# excluding vendored trees and the LICENSES/ directory.
mapfile -t PROJECTS < <(
PROJECTS=()
while IFS= read -r line || [[ -n "${line}" ]]; do
[[ -n "${line}" ]] && PROJECTS+=("${line}")
done < <(
git ls-files \
-cmo \
--exclude-standard \
Expand Down Expand Up @@ -94,7 +97,7 @@ check_project() {
}

fail=0
for proj in "${PROJECTS[@]}"; do
for proj in ${PROJECTS[@]+"${PROJECTS[@]}"}; do
if ! check_project "${proj}"; then
echo "ERROR: ${proj} contains disallowed Python license(s)" >&2
fail=1
Expand Down
Loading