Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions benchmarking/workloads/manifests/workloads.yaml.tmpl
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,11 @@ spec:
- "--metrics-listen-addr=:9090"
- "--data-dir=/tmp/glutton"
- "--mode=http"
# Hold ResumeActor open until port 80 actually answers.
readyz:
httpGet:
path: /readyz
port: 80
workerSelector:
matchLabels:
workload: benchmark-ateom
Expand Down
5 changes: 5 additions & 0 deletions cmd/benchmarking/glutton/main.go
Original file line number Diff line number Diff line change
Expand Up @@ -136,6 +136,11 @@ func main() {
// (re-exposable as additional routes if/when needed).
mux := http.NewServeMux()
mux.HandleFunc("/ping", httpPingHandler(svc))
// ateom blocks RestoreWorkload until this returns 200, so ResumeActor
// cannot report success before /ping is reachable.
mux.HandleFunc("/readyz", func(w http.ResponseWriter, r *http.Request) {

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We probably need to serve /readyz regardless of mode (grpc vs. http). Apologies for not spotting this earlier.

w.WriteHeader(http.StatusOK)
})
// otelhttp at the mux level + per-handler span follows
// docs/dev/best-practices/tracing.md: extract incoming context,
// then name the span after the operation in each handler.
Expand Down
Loading