fix: cleanup uses fresh context after volume create failure - #541
Open
Mesut Oezdil (mesutoezdil) wants to merge 1 commit into
Open
fix: cleanup uses fresh context after volume create failure#541Mesut Oezdil (mesutoezdil) wants to merge 1 commit into
Mesut Oezdil (mesutoezdil) wants to merge 1 commit into
Conversation
Both cleanup paths for a half-created actor reused the caller's context. When a canceled or expired context is what made creation fail, every delete failed immediately and the external volumes leaked. Route both sites through cleanupActorVolumes, which detaches from the caller's context and applies its own 30s timeout.
Mesut Oezdil (mesutoezdil)
force-pushed
the
fix/volume-cleanup-context
branch
from
July 29, 2026 18:44
db6998f to
9dc8247
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A half-created actor has two cleanup paths, and both reused the caller's ctx: the one after CreateVolume fails, and the one after the DB write fails in CreateActor. When a canceled or expired ctx is what caused the failure, every delete failed for the same reason right away and the external volumes leaked.
Both now go through cleanupActorVolumes, which detaches from the caller's ctx and applies its own 30s timeout. Test covers the canceled-ctx case.