[minor] stamp OpenTelemetry span attributes in UpdateActor - #512
Merged
Eitan Yarmush (EItanya) merged 1 commit intoJul 29, 2026
Merged
Conversation
Collaborator
Krisztian F (krisztianfekete)
approved these changes
Jul 27, 2026
Krisztian F (krisztianfekete)
left a comment
Contributor
There was a problem hiding this comment.
This looks good to me, just added a nit test comment.
| if err := validateUpdateActorRequest(req); err != nil { | ||
| return nil, err | ||
| } | ||
| setSpanActorRefAttributes(ctx, req.GetActor().GetAtespace(), req.GetActor().GetName()) |
Contributor
There was a problem hiding this comment.
Do you mind adding a failed lookup test case so a missing actor path is guarded? Similar to
substrate/cmd/ateapi/internal/controlapi/pause_actor_test.go
Lines 32 to 52 in aa1d14a
Contributor
Author
There was a problem hiding this comment.
Updated! Thank you
Troy Chiu (troychiu)
force-pushed
the
fix-update-actor-span-attributes
branch
from
July 27, 2026 21:06
b76b5fb to
d57ea55
Compare
Krisztian F (krisztianfekete)
approved these changes
Jul 28, 2026
Troy Chiu (troychiu)
force-pushed
the
fix-update-actor-span-attributes
branch
from
July 28, 2026 23:09
d57ea55 to
09d977e
Compare
Contributor
Author
|
Rebased onto main. |
Contributor
Author
|
Eitan Yarmush (@EItanya) can we merge this? |
Eitan Yarmush (EItanya)
previously approved these changes
Jul 29, 2026
Collaborator
|
Sorry, ended up with conflicts from another merge :( |
Troy Chiu (troychiu)
force-pushed
the
fix-update-actor-span-attributes
branch
from
July 29, 2026 17:49
09d977e to
8387b56
Compare
Contributor
Author
|
Just rebased onto main! Thank you. |
Eitan Yarmush (EItanya)
approved these changes
Jul 29, 2026
Eitan Yarmush (EItanya)
merged commit Jul 29, 2026
5bf19fc
into
agent-substrate:main
11 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds missing OpenTelemetry span attributes in UpdateActor and corresponding tests.