[codex] fix Ruff CI scope - #1
Merged
Merged
Conversation
melody-ling-L
marked this pull request as ready for review
June 20, 2026 10:35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
astral-sh/ruff-actionwithsrc: ./srcinstead of embeddingsrc/insideargs.0.15.18, matching the version used by the failing run.src/data_prep.pyandsrc/eval_runner_v2.py.Root cause
ruff-actionappends itssrcinput to the Ruff command. Because the workflow leftsrcat its default repository root while also passingsrc/insideargs, CI executed effectively:That unintentionally linted notebooks, generated reports, and scripts in addition to
src/, producing a persistent red badge.Impact
CI now enforces the repository's intended policy: E/F/W checks on production source code under
src/. The source tree itself is clean; this does not suppress real source errors or change benchmark results.Validation
srcinput behavior.0.15.18locally with the exact intended command:ruff check --select E,F,W --ignore E501 ./src.All checks passed!python3 -m compileall -q srcpassed.git diff --checkpassed.