Skip to content

[codex] fix Ruff CI scope - #1

Merged
melody-ling-L merged 1 commit into
mainfrom
codex/fix-ruff-ci
Jun 20, 2026
Merged

[codex] fix Ruff CI scope#1
melody-ling-L merged 1 commit into
mainfrom
codex/fix-ruff-ci

Conversation

@melody-ling-L

Copy link
Copy Markdown
Collaborator

What changed

  • Configure astral-sh/ruff-action with src: ./src instead of embedding src/ inside args.
  • Pin Ruff to 0.15.18, matching the version used by the failing run.
  • Remove three genuinely unused imports from src/data_prep.py and src/eval_runner_v2.py.

Root cause

ruff-action appends its src input to the Ruff command. Because the workflow left src at its default repository root while also passing src/ inside args, CI executed effectively:

ruff check src/ ... <repository-root>

That unintentionally linted notebooks, generated reports, and scripts in addition to src/, producing a persistent red badge.

Impact

CI now enforces the repository's intended policy: E/F/W checks on production source code under src/. The source tree itself is clean; this does not suppress real source errors or change benchmark results.

Validation

  • Reproduced the failing command from GitHub Actions logs.
  • Verified the official Ruff Action src input behavior.
  • Ran Ruff 0.15.18 locally with the exact intended command: ruff check --select E,F,W --ignore E501 ./src.
  • Result: All checks passed!
  • python3 -m compileall -q src passed.
  • Workflow YAML parsing and git diff --check passed.

@melody-ling-L
melody-ling-L marked this pull request as ready for review June 20, 2026 10:35
@melody-ling-L
melody-ling-L merged commit 22d8b2a into main Jun 20, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant