Repository navigation
Preserve local environments during concurrent setup - #21
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Local setup checked for
.envand then opened that pathname for truncating writes, so another setup could create an environment in between and have it overwritten. Create the file exclusively and write through the owned descriptor. Existing entries, including dangling links, are preserved without reading the template; write failures never unlink a shared pathname.Prepare source version 1.0.1, keeping the package, MCP, container references and source-download instructions consistent. Add regressions for a competing writer, concurrent creators, existing entries, missing templates and failed-write cleanup.
Validation: the exact-head PR workflow passed verification with disposable PostgreSQL and browser checks, recovery and source packaging. Local Windows lint/typecheck, both build paths and fresh extracted-source checks also passed; the archive matched all 129 tracked blobs. The controlled subprocess race overwrites a competing environment on the earlier source and preserves it after this change. The Windows host skips file-symlink creation because it lacks that privilege; Linux CI exercises that test.
The aggregated CodeQL check still reports two potential filesystem-race warnings, so the overall check set is not entirely green. One points to
scripts/setup-env.mjs:24: the earlylstatpreserves existing-entry behavior, whileopenSync('.env', 'wx', 0o600)is the actual exclusive creation boundary and returns EEXIST without overwriting a competing file. The query matches check/use order but does not examine exclusive-open flags. The second points totests/setup-env.test.ts:90, which intentionally creates a fresh fixture target after asserting its absence to test linked and dangling entries. The tested atomic controls and isolated fixture context do not establish a surviving attacker-controlled overwrite. The annotations remain visible; no query gate or alert state was changed.