chore(did-hosting-ui): drop the walletProfile capability probe - #178
Merged
Conversation
`isWalletProfileAvailable()` existed so #177 could merge before the wallet method it depends on did. That has now shipped (OpenVTC/vta-browser-plugin#145), so the second probe describes a wallet build that does not exist: every extension that exposes `proxyLogin` exposes `walletProfile` too. Folded into `isWalletProxyAvailable()`, which now checks the three methods this screen actually calls. The proxy button is no longer conditionally hidden, and the secondary button no longer changes its label to stand in as the primary route — both were arms for a wallet nobody has. Presence detection stays and is not the same thing: the extension may simply not be installed, which is why the buttons are gated at all. Nothing about the flow changes. `resolveProxyEntry` → `loginWithWalletProxy` is untouched, the flow visualization with it, and "Login as a different identity…" keeps the entry picker for an operator holding more than one persona here. Signed-off-by: Glenn Gore <glenn.g@affinidi.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #177.
isWalletProfileAvailable()existed so that PR could merge before the wallet method it depends on did — the "land in either order" property. OpenVTC/vta-browser-plugin#145 has now shipped, so the second probe describes a wallet build that does not exist: every extension that exposesproxyLoginexposeswalletProfiletoo.Folded into
isWalletProxyAvailable(), which now checks the three methods this screen actually calls.What goes
profileAvailable— an arm for a wallet nobody has.resolveProxyEntry's "This VTI Wallet build cannot choose an identity for a site. Update the extension…" message, which can no longer be reached.What stays
Presence detection, which is not the same thing — the extension may simply not be installed, and that is why the buttons are gated at all. The probe now just asks for everything the screen uses instead of splitting into two questions with one possible answer.
"Login as a different identity…" and the entry picker behind it. That is a real capability for an operator holding more than one persona at this RP, not a compatibility arm, and it stays behind an explicit click because reaching it discloses the vault to this page.
Nothing about the flow changes:
resolveProxyEntry→loginWithWalletProxyis untouched, and the flow visualization with it.Checks
npm run typecheckcleannpm test— 36 tests, 4 files, 0 failuresisWalletProfileAvailable/profileAvailableremain