refactor: make dist/ ESM#250
Open
slagiewka wants to merge 1 commit into
Open
Conversation
slagiewka
commented
Jun 10, 2026
| "module": "nodenext", | ||
| "moduleResolution": "nodenext", | ||
| "rewriteRelativeImportExtensions": true, | ||
| "erasableSyntaxOnly": true, |
Contributor
Author
There was a problem hiding this comment.
This isn't strictly necessary and can be removed. However, my experience shows that it's beneficial to use it unless enums are required. It ensures that the emitted code stays as close as possible to the source.
It also makes it extremely easy to enable node's type stripping. Since this project's development is mostly running tests and vitest has no issues running TS anyway, it's not a direct benefit. Should you want to drop vitest, however, it's way easier then 😉
Owner
|
Thanks! I have to admit that I'm one of those people with an irrational hatred of file extensions in imports 😂 so while this is a nice modernization, I'll need to think about it and get over it before merging |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey, I saw you're modernising the setup and that there's likely another major coming up.
If this interests you, the following changes make the output
dist/ESM. For node.js users, it will require 20.19+ (package.jsoncurrently specifies engine >= 18).