Skip to content

feat!: improve curl safety, non-apt warnings, and add outputs - #2

Merged
abn merged 4 commits into
mainfrom
improve-action
May 29, 2026
Merged

feat!: improve curl safety, non-apt warnings, and add outputs#2
abn merged 4 commits into
mainfrom
improve-action

Conversation

@abn

@abn abn commented May 29, 2026

Copy link
Copy Markdown
Contributor

Description

This PR improves the code quality, security, and developer experience of the setup-cli composite action. It also introduces structured outputs and better warnings for non-Debian based Linux environments.

This change includes a breaking change footer to instruct release-please to trigger the first major release (v1.0.0).

Key Enhancements

  1. Security & Code Quality (Resolved eval smells):

    • Replaced string-interpolated eval commands for injecting GITHUB_TOKEN authentication with bash arrays (AUTH=()). This prevents authentication tokens from appearing in execution traces and makes command structure robust.
  2. Robust Fallbacks:

    • Added || true to the public API curl command in the version resolution block to ensure transient network issues do not abruptly trip pipefail / errexit before the action can output a friendly error message.
  3. Exposed Action Outputs:

    • Added outputs to the action:
      • version: The resolved version tag of the AetherPak CLI that was installed.
      • path: The absolute installation directory.
    • Useful for downstream workflow tasks and testing automation.
  4. Non-Apt OS Warnings:

    • Emits a GitHub Action ::warning:: if the runner is missing required packages but has no apt-get package manager installed (e.g., self-hosted Fedora or Arch Linux runners), rather than failing silently.

BREAKING CHANGE

This action now enforces strict Linux OS verification, refactors token interpolation to use array expansion, and introduces new action outputs.

@abn
abn merged commit e0f32c6 into main May 29, 2026
1 check passed
@abn
abn deleted the improve-action branch May 29, 2026 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant