Repository navigation
With ankles, the shin stops at the ankle (#174); Aether 0.810.0 - #176
Merged
Merged
Conversation
With `ankles` set, each calf's capsule was built as specified: its cap reached a radius past the ankle, through the foot's place, and rested on the ground beside the foot. A standing figure with soft ankles put 42% of its weight on its shins' end caps. The shin is now built with its ankle end drawn in by its radius, so its cap ends at the ankle. Its knee end, radius and spec are unchanged, and the foot's joint is still made at the ankle. That figure now stands entirely on its feet. Without ankles the calf is the reference's, unchanged. human_bone_far_end gives a built bone's far end in its body's frame: the ankle for a calf with ankles (the foot's joint), else its capsule's end farther from its joint. Consumers that took a calf's ankle from its shin's capsule should read it here. test_human checks the shin's shape against the ankle and the reference, the far ends, and the issue's measure (shins against feet, as shares of the figure's weight). The old capsule fails it. AE_PIN moves to 0.810.0, the latest release (the gate passes on it unchanged), and the README's install line, left at 0.806.0, follows.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #174. Also moves CI to Aether 0.810.0, the latest release.
The fix
With
anklesset, each calf's capsule was built as specified. Its cap reached a radius (8 cm) past the ankle, through the space the foot occupies, and rested on the ground beside the foot.The shin is now built with its ankle end drawn in by its radius, so its cap ends at the ankle. Unchanged:
Standing, with every joint stiff but the ankles soft (the case the issue measured in ae3d), as shares of the figure's weight:
human_bone_far_endA built bone's far end in its body's frame:
For ae3d: its
bone_far_endtakes a calf's ankle from the far end of the shin's capsule. With ankles that end is now a radius short of the ankle, so it should callhuman.human_bone_far_end.Tests
test_humanhas 134 checks, the new ones intest_ankle_shins:With the shortening disabled, the shape checks fail by 0.08 m and the load checks by 42%.
Pins