Repository navigation
sit: the hands rest where the arms reach with the elbows bent, on any seat - #837
Merged
Merged
Conversation
… seat (closes #834) hands_on_thighs put each hand SIT_HANDS (0.6) of the way from the hip to the knee, whatever the arm could reach. On a high seat the thighs slope down to the knees, so the hands landed far from the shoulders and the arms locked all but straight: 7.1 degrees from straight on a 0.5 m seat, 5.7 on a 0.6 m one, against 50 on the 0.4 m log. Standing up then re-solved each arm from that pose, and both snapped 7.6 to 10.1 degrees in a step. Now a hand rests at SIT_HANDS where the shoulder reaches it with the elbow bent SIT_ELBOW (30 degrees) at least, and else nearer the hip, as far as that holds (hand_share, exact along the thigh), down to SIT_HANDS_NEAREST. A person sitting high rests the hands further up the thighs, elbows bent. test_sit's round log, its top 0.6 m up, is held to the 6-degree pop limit again: its worst turn in a step is 2.7 degrees, and 7.6 without the fix, which fails. The 0.4 m squared log is unchanged at 3.0.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On a seat over about 0.45 m high, a sitter's arms snapped 7.6 to 10.1 degrees in one step as it started to stand up (#834). The cause was where the hands rested.
Cause.
hands_on_thighsput each handSIT_HANDS(0.6) of the way from the hip to the knee, whatever the arm could reach.Fix. A hand rests at
SIT_HANDSwhere the shoulder reaches it with the elbow bentSIT_ELBOW(30 degrees) at least. Otherwise it rests nearer the hip, as far as that holds, down toSIT_HANDS_NEAREST(0.15). The share is solved exactly along the thigh from the arm's two lengths (hand_share). A person sitting high rests the hands further up the thighs, elbows bent. It is clip-agnostic: it reads only the figure's own arm lengths.Test.
test_sit's round log, its top 0.6 m up, is held to the 6-degree pop limit again, which #832 had held at 8 degrees for this issue. It turns 2.7 degrees at the worst now, and fails at 7.6 without the fix.Tested locally: on Aether 0.834.0 and aephysics f0bd6d6, the motion gate (34 suites) plus
test_go_to,test_sit,test_lie,test_locomotion,test_characters_meet,test_physics,test_ikandtest_gmathall pass, 42 of 42. The plaza scorecard is not run: no one sits in the plaza.Dependencies: unchanged, held as on main (Aether 0.834.0, aephysics f0bd6d6) for aether#3023 and aether-ui#220.
Closes #834. Part of #825 and #790.