Fix selected icon display for options beyond initial pagination limit#37
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Icons loaded via infinite scroll (beyond the initial 50) lose their display after selection. When the dropdown closes, limit resets to 50, removing the selected icon from the options array. The Combobox can no longer resolve the value to a full option object and falls back to showing the raw CSS class string instead of the icon preview and label. The same happens after saving and reloading the page.
The fix ensures the selected icon is always present in the options array while the dropdown is closed, so the Combobox can resolve it for display. When the dropdown is open, the list remains unmodified.