fix(export_document): harden wkhtmltopdf subprocess - #922
Draft
Vigneshsekar wants to merge 1 commit into
Draft
Conversation
Vigneshsekar
marked this pull request as draft
August 20, 2026 11:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
wkhtmltopdfexecutable and validate its canonical path, permissions, basename, and symlink targetfrappe-subprocess-execcallSecurity review
The subprocess receives an argv list, never a shell command. Page size and orientation are allowlisted, margins and timeout are bounded integers, header/footer paths are internally generated absolute temp paths, and document HTML is passed on stdin rather than interpolated into argv.
Testing
bench --site jarvis.localhost run-tests --app jarvis --module jarvis.tests.test_export_document_furniture(68 passed)bench --site jarvis.localhost run-tests --app jarvis --module jarvis.tests.test_export_document(56 passed)pre-commit run --files jarvis/tools/_export/document/furniture.py jarvis/tests/test_export_document_furniture.py