Skip to content

Add compact progress output - #23

Merged
adrianmross merged 1 commit into
mainfrom
feat/progress-status
Jun 4, 2026
Merged

Add compact progress output#23
adrianmross merged 1 commit into
mainfrom
feat/progress-status

Conversation

@adrianmross

Copy link
Copy Markdown
Owner

Summary

  • add compact progress reporting for host prep commands
  • keep JSON stdout clean and suppress progress with --silent
  • add --verbose to print every progress step as normal stderr log lines
  • cover silent/verbose behavior in the hermetic CLI contract test

Validation

  • go test ./...
  • go build -o /private/tmp/oci-hop-progress ./cmd/oci-hop

Copilot AI review requested due to automatic review settings June 4, 2026 20:51

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds compact, configurable progress reporting (stderr) to the CLI’s host-preparation flows so interactive use is less noisy while keeping JSON stdout outputs machine-friendly.

Changes:

  • Introduces a progressReporter that uses a spinner on TTYs and plain step lines otherwise, with --silent and --verbose controls.
  • Wires progress steps into hop (root host mode) and host prep subcommands (ensure, repair --ensure, ssh).
  • Extends the hermetic CLI contract test to cover --silent and --verbose behavior.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
README.md Documents the new compact progress behavior and the --silent / --verbose flags.
cmd/oci-hop/main.go Adds the progress reporter + global flags and integrates progress steps into host-prep command execution.
cmd/oci-hop/main_test.go Adds contract assertions for silent/verbose progress output behavior.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread README.md Outdated
Comment on lines +80 to +82
Text commands print compact progress on stderr while they prepare auth,
Bastion, and SSH config. Use `--silent` to suppress progress output, or
`--verbose` to print every progress step as plain log lines.
@adrianmross
adrianmross force-pushed the feat/progress-status branch 4 times, most recently from 7024d45 to e768920 Compare June 4, 2026 23:51
@adrianmross
adrianmross force-pushed the feat/progress-status branch from e768920 to b326a42 Compare June 4, 2026 23:54
@adrianmross
adrianmross merged commit f5345fd into main Jun 4, 2026
1 check passed
@adrianmross
adrianmross deleted the feat/progress-status branch June 4, 2026 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants