Repository navigation
Season 3 playoffs are scored on points too - #144
Merged
Merged
Conversation
The semi-final VOD shows both games going on after a line, each ending when a side reached 13 points. SeasonFormat.round_robin_scoring becomes scoring (every game of the season), and scoring_for no longer takes the match type. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Season 3's playoffs (the semi-final and the final,
double_elimination) are scored on points like its round robin: first to 13 points, a point per square plus 2 per completed line. In the semi-final VOD both games go on after a line and end when a side reaches 13.This commit (
a179804) was meant for #139, but it was pushed toseason-3after #139 merged, so it never reached main. With the released 1.5.1, the site's Season 3 playoff matches failseason_scoring("a season 3 double_elimination game is lockout"): site PRs #157 and #158.SeasonFormat.round_robin_scoring→scoring: one scoring for every game of the season.validation.scoring_for(season)no longer takes the match type. Extraction and theseason_scoringrule use it.match validatehelp) and tests updated.Cherry-picked onto main. One conflict in
extract.pywith the time-limitgame_endloop (#140), where I kept main's loop and switched it to the new call.Checks: 576 tests pass, Ruff clean.
scadustats match validatefrom this branch on site branchseason-3-page(every Season 3 match, playoffs included): 0 of 134 matches have issues.After merge: release, so the site's CI (
scadustats@latest) passes on #157 and #158.🤖 Generated with Claude Code