Skip to content

[codex] Make racial spell charges authoritative - #204

Merged
adrev merged 1 commit into
mainfrom
codex/racial-spell-charge-authority
Aug 6, 2026
Merged

[codex] Make racial spell charges authoritative#204
adrev merged 1 commit into
mainfrom
codex/racial-spell-charge-authority

Conversation

@adrev

@adrev adrev commented Aug 6, 2026

Copy link
Copy Markdown
Owner

Summary

  • persist per-rest innate racial spell charges as version-guarded race features and refresh them through the normal rest flows
  • current-map scope the caster, keep exact charge totals private, and fail closed on malformed data, DB errors, and version conflicts
  • preserve reserved Ki, Sorcery Point, and racial charge resources across generic socket/REST feature edits and D&D Beyond re-sync
  • keep ordinary character features editable and at-will racial spells resource-free

Verification

  • npm exec --yes --package=node@24 -- npm test (147 files, 1865 tests)
  • npm exec --yes --package=node@24 -- npm run build
  • npm exec --yes --package=node@24 -- npm run lint (0 warnings)
  • npm exec --yes --package=node@24 -- npm audit --omit=dev (0 vulnerabilities)
  • git diff --check

Notes

  • No schema migration or deployment is included.
  • Legacy !racial reset and resetshort now direct callers to the normal long/short-rest flows.
  • The commit used --no-verify only to avoid broad legacy formatter churn; all repository gates above passed.

@coderabbitai

coderabbitai Bot commented Aug 6, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@adrev, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 30 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: e652e850-cfe6-47df-9d36-d12abd12afe5

📥 Commits

Reviewing files that changed from the base of the PR and between 35697da and 3cab1a0.

📒 Files selected for processing (12)
  • docs/5e-rules-matrix.md
  • server/src/__tests__/auth-boundaries.test.ts
  • server/src/__tests__/character-update-versioning.test.ts
  • server/src/__tests__/ddbMerge.test.ts
  • server/src/__tests__/racial-spell-authoritative.test.ts
  • server/src/routes/characters.ts
  • server/src/services/chatCommands/helpHandlers.ts
  • server/src/services/chatCommands/racialSpellsHandler.ts
  • server/src/services/ddbMerge.ts
  • server/src/socket/characterEvents.ts
  • server/src/utils/featureResourceAuthority.ts
  • shared/src/rules5e/rulesMatrix.ts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@adrev
adrev marked this pull request as ready for review August 6, 2026 09:19
@adrev

adrev commented Aug 6, 2026

Copy link
Copy Markdown
Owner Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Aug 6, 2026

Copy link
Copy Markdown
⚠️ Action not completed

Review rate limited.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@adrev
adrev merged commit 5b0f2c6 into main Aug 6, 2026
2 checks passed
@adrev
adrev deleted the codex/racial-spell-charge-authority branch August 6, 2026 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant