Skip to content

Guard death-save persistence with character versions - #201

Merged
adrev merged 2 commits into
mainfrom
codex/death-save-version-authority
Aug 6, 2026
Merged

Guard death-save persistence with character versions#201
adrev merged 2 commits into
mainfrom
codex/death-save-version-authority

Conversation

@adrev

@adrev adrev commented Aug 6, 2026

Copy link
Copy Markdown
Owner

Summary

  • compute ordinary death-save counters without mutating live combat first
  • guard the character write with the selected characters.version and fail closed on conflicts/errors
  • consume the once-per-round marker only after a confirmed save, including natural-20 healing and third-success stabilization
  • preserve hidden-token stat/chat scoping and reconcile post-commit combat-state persistence

Validation

  • Node 24 focused combat tests: 71 passed
  • Node 24 full suite: 145 files, 1,806 tests passed
  • production build passed
  • ESLint passed with zero warnings
  • npm audit --omit=dev: 0 vulnerabilities
  • git diff --check: clean

No deployment in this PR.

@coderabbitai

coderabbitai Bot commented Aug 6, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@adrev, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 19 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: f628bb0f-880c-4f09-8353-613637a9179c

📥 Commits

Reviewing files that changed from the base of the PR and between cec11d0 and c144409.

📒 Files selected for processing (4)
  • server/src/__tests__/character-version-propagation.test.ts
  • server/src/__tests__/combat-hp-events.test.ts
  • server/src/services/CombatService.ts
  • server/src/socket/combat/hpEvents.ts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@adrev
adrev marked this pull request as ready for review August 6, 2026 08:17
@adrev

adrev commented Aug 6, 2026

Copy link
Copy Markdown
Owner Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Aug 6, 2026

Copy link
Copy Markdown
⚠️ Action not completed

Review rate limited.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@adrev
adrev merged commit af4cbd3 into main Aug 6, 2026
2 checks passed
@adrev
adrev deleted the codex/death-save-version-authority branch August 6, 2026 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant