[Release] Stage to Main#824
Merged
Merged
Conversation
…778) * Fix delay with config-based A/B testing api initiation Resolves: [MWPW-194995(https://jira.corp.adobe.com/browse/MWPW-194995) **Test URLs:** - Before: https://stage--da-dc--adobecom.aem.page/acrobat/online/compress-pdf?martech=off&unitylibs=stage - After: https://stage--da-dc--adobecom.aem.page/acrobat/online/compress-pdf?martech=off&unitylibs=target-test **Implementation details:** `this.pageConfigPromise = null (line 189)` initializes the field so it's always defined on the instance. `this.pageConfigPromise = this.ensurePageConfig() `(line 792, inside initActionListeners when b === this.block) fires the fetch the moment the verb-widget finishes rendering (for performance reasons), no await so it doesn't block listener setup. The promise is stored so it can be joined later. `await (this.pageConfigPromise || this.ensurePageConfig()) `(line 580, in handleFileUpload) if the widget has rendered (normal path), we await the already in flight or resolved promise; if somehow pageConfigPromise is null (edge case: upload triggered before initActionListeners ran with the block), we fall back to calling it directly. The existing pageConfigFetched guard inside ensurePageConfig still prevents double execution. --------- Co-authored-by: Arushi Gupta <65466846+arugupta1992@users.noreply.github.com> Co-authored-by: Arushi Gupta <arugupta@Arushis-MacBook-Pro.local> Co-authored-by: Sanjay Saravanan <75960494+sanjayms01@users.noreply.github.com> Co-authored-by: Vipul Gupta <vipugpta@gmail.com> Co-authored-by: vipulg <vipulg@adobe.com> Co-authored-by: Nishant Thakur <nishant.thakur.ece@gmail.com> Co-authored-by: Ratko Zagorac <90400759+zagi25@users.noreply.github.com> Co-authored-by: Manasvi Agrawal <maagrawal@adobe.com>
Reverts #810 And also fixes the crash issue in Acrobat workflow for the transition screen. --------- Co-authored-by: vipulg <vipulg@adobe.com>
…url (#809) <!-- Before submitting, please review all open PRs. --> * Add redirect query param with current time in redirect url * It's needed for the dashboard for monitoring the improvements done for upload optimization Resolves: [MWPW-198299](https://jira.corp.adobe.com/browse/MWPW-198299) **Test URLs:** - Before: https://main--da-dc--adobecom.aem.live/acrobat/online/word-to-pdf?martech=off&unitylibs=stage - After: https://main--da-dc--adobecom.aem.live/acrobat/online/word-to-pdf?martech=off&unitylibs=redirect-query-param **Testing Notes** Verfiy that the redirected url to acrobat web has the query param redirectTime with value as current time. This query param should be there for all acrobat verbs --------- Co-authored-by: Sanjay Saravanan <75960494+sanjayms01@users.noreply.github.com> Co-authored-by: Arushi Gupta <65466846+arugupta1992@users.noreply.github.com> Co-authored-by: Arushi Gupta <arugupta@Arushis-MacBook-Pro.local> Co-authored-by: Vipul Gupta <vipugpta@gmail.com> Co-authored-by: vipulg <vipulg@adobe.com> Co-authored-by: Nishant Thakur <nishant.thakur.ece@gmail.com> Co-authored-by: Ratko Zagorac <90400759+zagi25@users.noreply.github.com> Co-authored-by: Manasvi Agrawal <maagrawal@adobe.com> Co-authored-by: Ruchika Sinha <tek10248@Ruchikas-MacBook-Pro.local>
<!-- Before submitting, please review all open PRs. --> * Onboard resume builder for express Resolves: [MWPW-197381](https://jira.corp.adobe.com/browse/MWPW-197381) **Test URLs:** - Before: https://resume-builder--da-express-milo--adobecom.aem.page/drafts/methomas/express/create/resume?unitylibs=stage - After: https://resume-builder--da-express-milo--adobecom.aem.page/drafts/methomas/express/create/resume?unitylibs=express-2 - New `verb-dropzone` block for Express pages — renders a dropzone area with upload button, drag-hint text, file limit text, and legal footer authored via the Unity block. ### Testing Notes: Drag & Drop - Drop listeners are attached to `document.body` (not scoped to a div), so dropping a file **anywhere on the page** triggers upload while the dropzone is in the viewport. - Listeners are added/removed via `IntersectionObserver` — dropping a file when the dropzone is scrolled out of view should **not** trigger upload. File Input (Click to Upload) - Clicking the upload button opens the file picker restricted to `image/jpeg, image/jpg, image/png, image/webp`. - Selecting an unsupported file type should show a validation error toast. Redirect Query Param (`x_api_client_location`) - On redirect, the URL should contain `x_api_client_location` computed from the page path: strips `/express/` prefix, reverses path segments, joins with `_`. - Example: `/express/create/resume` → `x_api_client_location=resume_create` - Verify the correct value appears in the redirect URL for the page under test. - Test page if created will need to be created inside a express folder Transition Screen - Upload should show a splash/transition screen (from `/express/unity/splashscreen` fragment, mounted on `body`). - Verify it appears on file drop/select and clears on redirect. User logged in status - Test the flow for anonymous users. There is a discussion going on where we might need to support signed in users to upload files too. However this PR doesn't touch that yet. So scope for this PR is anonymous user and signed in user experience will be tested separately Regression - Please do a regression on an existing acrobat verb with unitylibs=express-2 to make sure everything works as expected --------- Co-authored-by: Sanjay Saravanan <75960494+sanjayms01@users.noreply.github.com> Co-authored-by: Arushi Gupta <65466846+arugupta1992@users.noreply.github.com> Co-authored-by: Arushi Gupta <arugupta@Arushis-MacBook-Pro.local> Co-authored-by: Vipul Gupta <vipugpta@gmail.com> Co-authored-by: vipulg <vipulg@adobe.com> Co-authored-by: Nishant Thakur <nishant.thakur.ece@gmail.com> Co-authored-by: Ratko Zagorac <90400759+zagi25@users.noreply.github.com> Co-authored-by: Manasvi Agrawal <maagrawal@adobe.com> Co-authored-by: Ruchika Sinha <tek10248@Ruchikas-MacBook-Pro.local>
…817) * Updating pdfliteWasm per the latest 1.13.0 pdflite update to add fix for invalid pdf Resolves: [MWPW-197792](https://jira.corp.adobe.com/browse/MWPW-197792) **Testing Steps** - Use the pdf attached in ticket and upload onto the page - Notice that the error toast appears as expected and should for any files that have more than 10 pages **Test URLs:** - Before: https://stage--da-dc--adobecom.aem.page/acrobat/online/ai-resume-builder?unitylibs=stage - After: https://stage--da-dc--adobecom.aem.page/acrobat/online/ai-resume-builder?unitylibs=MWPW-197792
* Remove the 512x512 min dimension restriction for firefly to match in-product experience Resolves: [MWPW-190444](https://jira.corp.adobe.com/browse/MWPW-190444) **Testing Details** *Happy Path* - Visit https://stage--da-cc--adobecom.aem.page/products/firefly/features/sticker-generator?unitylibs=MWPW-190444 and upload an image smaller than 512x512 dimensions - Verify that you do not get an error toast and the upload actually occurs and you are redirected to product *Validate existing experiences with dimension checks* - Visit https://stage--da-cc--adobecom.aem.page/products/photoshop-lightroom?unitylibs=MWPW-190444 - Upload an image that is greater than 8k resolution and verify that the error toast appears as expected **Test URLs:** - Before: https://stage--da-cc--adobecom.aem.page/products/firefly/features/sticker-generator?unitylibs=stage - After: https://stage--da-cc--adobecom.aem.page/products/firefly/features/sticker-generator?unitylibs=MWPW-190444
## Description - Onboard 7 new image-to-PDF verbs in `workflow-acrobat`: `image-to-pdf`, `bmp-to-pdf`, `gif-to-pdf`, `tiff-to-pdf`, `indd-to-pdf`, `psd-to-pdf`, `ai-to-pdf`. - Added HEIC support for all the 7 new verbs. > Companion da-dc PR (`MWPW-196015`) registers the verbs in the `verb-widget` block and adds `.heic` to the picker. Conversion routes through the `jpg-to-pdf` handoff path; FE sends the real verb and BE maps the path / sets `x_api_client_location`. ## Related Issue <!-- Link to the JIRA ticket or GitHub issue that this PR resolves --> Resolves: [MWPW-196281](https://jira.corp.adobe.com/browse/MWPW-196281) ## Test URLs <!-- List the URLs where the changes can be tested --> - https://mwpw-196015--da-dc--adobecom.aem.page/acrobat/online/test/image-to-pdf?unitylibs=mwpw-197470 - https://mwpw-196015--da-dc--adobecom.aem.page/acrobat/online/test/bmp-to-pdf?unitylibs=mwpw-197470 - https://mwpw-196015--da-dc--adobecom.aem.page/acrobat/online/test/gif-to-pdf?unitylibs=mwpw-197470 - https://mwpw-196015--da-dc--adobecom.aem.page/acrobat/online/test/tiff-to-pdf?unitylibs=mwpw-197470 - https://mwpw-196015--da-dc--adobecom.aem.page/acrobat/online/test/indd-to-pdf?unitylibs=mwpw-197470 - https://mwpw-196015--da-dc--adobecom.aem.page/acrobat/online/test/psd-to-pdf?unitylibs=mwpw-197470 - https://mwpw-196015--da-dc--adobecom.aem.page/acrobat/online/test/ai-to-pdf?unitylibs=mwpw-197470 ## Notes for QA **Upload experience & limits** - **Single-file experience:** one file uploads, converts, and hands off to the app. - **Multi-file:** selecting more than one file shows **no error toast** — the user is taken to the multi-file **feedback screen** in the app (files are not converted). - **No file-count limit:** selecting many files does not throw a "max files" error; they route to the feedback screen. - **Max file size: 100 MB** — a single file over 100 MB shows an error toast. - **Empty (0-byte) file** shows an error toast. - **No page-count limit.** - **All file types supported** — PDF, Office docs, and images (AI, INDD, PSD, BMP, GIF, TIFF, JPG, PNG) **+ HEIC** (`.heic`) **Redirection / handoff (`x_api_client_location`)** - Distinct verbs on the FE, but they route through the existing **`jpg-to-pdf`** conversion path on the BE. - After upload, the handoff URL uses the `jpg-to-pdf` path with **`x_api_client_location` set to the real verb** (e.g. `x_api_client_location=image-to-pdf`), not `jpg-to-pdf`. Please confirm the real verb appears in the handoff URL. - Signed-in users are redirected to the JPG-to-PDF tool in the app (same destination as `png-to-pdf`). **HEIC** - HEIC (`.heic`) is accepted in the picker and passes validation, BE support is live for this on stage. Verify a `.heic` upload completes the redirect successfully. --------- Co-authored-by: Manasvi Agrawal <maagrawal@Manasvis-MacBook-Pro.local>
…oard (#815) 1. Added parameter to classiffiy signedin vs signed out users 2. Added workflow parameter to all events 3. Synced the server error namin across events 4. Wrapped connector cal in try catch to record it's failures and success Resolves: [MWPW-NUMBER](https://jira.corp.adobe.com/browse/MWPW-NUMBER) **Test URLs:** - Before: https://main--da-cc--adobecom.aem.page/drafts/vipulg/doodlebug/rbg/vg-rbg?unitylibs=stage - After: https://main--da-cc--adobecom.aem.page/drafts/vipulg/doodlebug/rbg/vg-rbg?unitylibs=rbg-dashboard --------- Co-authored-by: Arushi Gupta <arugupta@Arushis-MacBook-Pro-3.local>
Includes all critical bug fixes and enhancements requested, and also some major bug fixes Resolves: *Critical*: [MWPW-198790 Download CTA not appearing above the fold post-upload](https://jira.corp.adobe.com/browse/MWPW-198790) [MWPW-198610 Mobile tab experience](https://jira.corp.adobe.com/browse/MWPW-198610) [MWPW-198862 Background-removed transparent image is freely downloadable](https://jira.corp.adobe.com/browse/MWPW-198862) [MWPW-198728 Unity Marquee Adjustments per UX Design](https://jira.corp.adobe.com/browse/MWPW-198728) *Major*: [MWPW- 198339 Arrow icon overlaps "Generate new background" text on the NBA tile on Adobe.com page](https://jira.corp.adobe.com/browse/MWPW-198339) [MWPW-198333 Play/pause button is not in a shadow when the error toast appears](https://jira.corp.adobe.com/browse/MWPW-198333) [MWPW-198329 Image upload cancel is navigating the users to home page for logged in user](https://jira.corp.adobe.com/browse/MWPW-198329) [MWPW-198325 1st time download is not opening the firefly edit page is new tab](https://jira.corp.adobe.com/browse/MWPW-198325) [MWPW-198212 Hover effect is not seen on the cards](https://jira.corp.adobe.com/browse/MWPW-198212) [MWPW-198209 Hover effect is not as per the figma for 'Edit in Firefly' button](https://jira.corp.adobe.com/browse/MWPW-198209) [MWPW-198113 Edit in firefly button position is not proper as per the figma](https://jira.corp.adobe.com/browse/MWPW-198113) [MWPW-198097 Dots are seen in the widget](https://jira.corp.adobe.com/browse/MWPW-198097) **Test URLs:** - Before: https://main--da-cc--adobecom.aem.page/products/firefly/features/remove-background?unitylibs=stage - After:https://main--da-cc--adobecom.aem.page/products/firefly/features/remove-background?unitylibs=vgrbg-bugFixes https://main--da-cc--adobecom.aem.live/drafts/vipulg/doodlebug/rbg/vg-rbg?unitylibs=vgrbg-bugFixes --------- Co-authored-by: vipulg <vipulg@adobe.com> Co-authored-by: Arushi Gupta <65466846+arugupta1992@users.noreply.github.com> Co-authored-by: Arushi Gupta <arugupta@Arushis-MacBook-Pro-3.local>
|
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
|
|
Collaborator
|
All the PRs are verified on stage. Regression as well looks fine from Acrobat, Ps, Lr and doodle pages. |
Ruchika4
approved these changes
Jun 18, 2026
vipu0303
approved these changes
Jun 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test URLs:
Doodlebug
Acrobat