feat(design-data): excludeFromLegacy token field + button corner-radius fix - #1294
feat(design-data): excludeFromLegacy token field + button corner-radius fix#1294GarthDB wants to merge 2 commits into
Conversation
…(vpk.1 group A)
- packages/design-data/components/{combo-box,number-field,text-area,text-field}.json:
rebind the leading-icon spacing entry from the nonexistent -400 step to the
existing -300 step; no consumer or Tokens Studio entry ever referenced -400.
…er-radius bindings Lets tokens without Tokens Studio precedent be authored directly in design-data without publishing to the legacy flat-key mirror; used it to add real button corner-radius tokens and resolve the SPEC-027 dangling bindings in button.json (bead spectrum-design-data-vpk.1). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
🦋 Changeset detectedLatest commit: 9da8be3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 10 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
🎨 Token Changes ReportTokens Changed (0)Original Branch: This comment was automatically generated by the token diff tool. 🤖 |
Run report for 9da8be37Total time: 3m 4s | Comparison time: 5m 46s | Estimated savings: 2m 41s (46.7% faster)
Expanded report
Changed files |
🧩 Component Schema Changes ReportComponent Schemas Changed (0 added, 0 deleted, 5 updated)Original Branch: New Branch: ✅ No Breaking ChangesThis PR contains only non-breaking changes to component schemas. 🔄 Non-Breaking Updatesbutton combo-box number-field text-area text-field This diff was generated automatically and contains only backward-compatible changes. This comment was automatically generated by the component schema diff tool. 🤖 |
Description
Adds an
excludeFromLegacyboolean token field: when true, the token isskipped during legacy-output generation (
packages/tokens/src) instead ofbeing written there. This lets new tokens without Tokens Studio precedent be
authored directly in
packages/design-datawithout polluting the legacymirror.
Uses the new flag to add real
buttoncorner-radiustokens(small/medium/large/extra-large, desktop+mobile) with literal pixel values
derived from
component-height-*÷ 2 — replacing the previously-dangling,calculated-only bindings in
button.json. Also fixes the binding key ordermismatch (
corner-radius-button-*→button-corner-radius-*) that wascausing SPEC-027 warnings.
Related Issue
bead
spectrum-design-data-vpk.1(SPEC-027 danglingtokenBindingstriage).
Motivation and Context
button.json's three corner-radius bindings referenced literal strings withno matching token anywhere in the corpus (
corner-radius-button-smalletc.)— these were purely calculated (height ÷ 2) design values with no design-data
representation. Rather than requiring Tokens Studio to publish first, this
adds a general mechanism for authoring net-new structured tokens directly in
design-data, opting them out of the legacy mirror until/unless TokensStudio catches up.
How Has This Been Tested?
cargo test -p design-data-core legacy::— all tests pass, including anew unit test for
excludeFromLegacy.migrate legacy-outputagainstpackages/design-data/tokens; diffed the generatedlayout.jsonagainstthe currently committed
packages/tokens/src/layout.json— byte-identical(confirms zero legacy-output impact from the new tokens).
moon run sdk:codegen+moon run design-data:validate— clean, no moreSPEC-027 warnings for
button.json's corner-radius bindings (remainingwarnings are pre-existing, unrelated vpk.1 items).
node tools/changeset-linter/src/cli.js check --fail-on-warnings— passes.Screenshots (if appropriate):
N/A
Types of changes
Checklist: