Skip to content

feat(design-data): excludeFromLegacy token field + button corner-radius fix - #1294

Open
GarthDB wants to merge 2 commits into
mainfrom
feat/button-corner-radius-exclude-from-legacy
Open

feat(design-data): excludeFromLegacy token field + button corner-radius fix#1294
GarthDB wants to merge 2 commits into
mainfrom
feat/button-corner-radius-exclude-from-legacy

Conversation

@GarthDB

@GarthDB GarthDB commented Jul 23, 2026

Copy link
Copy Markdown
Member

Description

Adds an excludeFromLegacy boolean token field: when true, the token is
skipped during legacy-output generation (packages/tokens/src) instead of
being written there. This lets new tokens without Tokens Studio precedent be
authored directly in packages/design-data without polluting the legacy
mirror.

Uses the new flag to add real button corner-radius tokens
(small/medium/large/extra-large, desktop+mobile) with literal pixel values
derived from component-height-* ÷ 2 — replacing the previously-dangling,
calculated-only bindings in button.json. Also fixes the binding key order
mismatch (corner-radius-button-*button-corner-radius-*) that was
causing SPEC-027 warnings.

Related Issue

bead spectrum-design-data-vpk.1 (SPEC-027 dangling tokenBindings
triage).

Motivation and Context

button.json's three corner-radius bindings referenced literal strings with
no matching token anywhere in the corpus (corner-radius-button-small etc.)
— these were purely calculated (height ÷ 2) design values with no design-data
representation. Rather than requiring Tokens Studio to publish first, this
adds a general mechanism for authoring net-new structured tokens directly in
design-data, opting them out of the legacy mirror until/unless Tokens
Studio catches up.

How Has This Been Tested?

  • cargo test -p design-data-core legacy:: — all tests pass, including a
    new unit test for excludeFromLegacy.
  • Built the CLI and ran migrate legacy-output against
    packages/design-data/tokens; diffed the generated layout.json against
    the currently committed packages/tokens/src/layout.json — byte-identical
    (confirms zero legacy-output impact from the new tokens).
  • moon run sdk:codegen + moon run design-data:validate — clean, no more
    SPEC-027 warnings for button.json's corner-radius bindings (remaining
    warnings are pre-existing, unrelated vpk.1 items).
  • node tools/changeset-linter/src/cli.js check --fail-on-warnings — passes.

Screenshots (if appropriate):

N/A

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

GarthDB and others added 2 commits July 22, 2026 14:52
…(vpk.1 group A)

- packages/design-data/components/{combo-box,number-field,text-area,text-field}.json:
  rebind the leading-icon spacing entry from the nonexistent -400 step to the
  existing -300 step; no consumer or Tokens Studio entry ever referenced -400.
…er-radius bindings

Lets tokens without Tokens Studio precedent be authored directly in
design-data without publishing to the legacy flat-key mirror; used it to
add real button corner-radius tokens and resolve the SPEC-027 dangling
bindings in button.json (bead spectrum-design-data-vpk.1).

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@changeset-bot

changeset-bot Bot commented Jul 23, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 9da8be3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 10 packages
Name Type
@adobe/spectrum-design-data Minor
@adobe/spectrum-component-api-schemas Patch
@adobe/design-system-registry Patch
@adobe/design-data-agent-mcp Patch
@adobe/design-data-mcp Patch
markdown-generator Patch
@adobe/token-corpus-migrate Patch
@adobe/token-naming-audit Patch
component-options-editor Patch
@adobe/spectrum-design-data-mcp Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions

Copy link
Copy Markdown
Contributor

🎨 Token Changes Report

Tokens Changed (0)

Original Branch: main
New Branch: feat/button-corner-radius-exclude-from-legacy


This comment was automatically generated by the token diff tool. 🤖

@github-actions

github-actions Bot commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

Run report for 9da8be37

Total time: 3m 4s | Comparison time: 5m 46s | Estimated savings: 2m 41s (46.7% faster)

Action Time Status Info
⬛️ SetupProto(0.57.4) 0ms Skipped
🟩 SyncWorkspace 9ms Passed
🟩 SyncProject(sdk) 11.3ms Passed
🟩 SyncProject(design-data-spec) 11.3ms Passed
🟩 SyncProject(design-data) 1.3ms Passed
⬛️ SetupToolchain(node:20.17.0) 23.6ms Skipped
⬛️ SetupToolchain(pnpm:10.17.1) 2ms Skipped
⬛️ SetupToolchain(javascript) 0ms Skipped
🟩 SetupEnvironment(javascript) 0.5ms Passed
⬛️ SetupEnvironment(javascript, sdk) 0.6ms Skipped
⬛️ InstallDependencies(javascript) 0.3ms Skipped
🟩 RunTask(design-data:validate-registry) 194.3ms Passed
⬛️ SetupToolchain(rust:1.88.0) 309.8ms Skipped
🟩 SetupEnvironment(rust, sdk) 203.6ms Passed
⬛️ InstallDependencies(rust, sdk) 8.4ms Skipped
🟩 RunTask(sdk:fmt-check) 1.4s Passed
🟩 InstallDependencies(javascript, sdk) 5.1s Passed
🟩 RunTask(sdk:codegen-check) 185.3ms Passed
🟩 RunTask(sdk:lint) 47.7s Passed
🟩 RunTask(sdk:test) 2m 51s Passed SLOW
And 5 more...
Expanded report
Action Time Status Info
🟩 RunTask(sdk:build) 2m 56s Passed SLOW
🟩 RunTask(design-data:legacy-output) 555.2ms Passed
🟩 RunTask(design-data:roundtrip-verify) 888.3ms Passed
🟩 RunTask(design-data:validate-dataset) 2.2s Passed
🟩 RunTask(design-data:validate) 1s Passed
Changed files
.changeset/button-corner-radius-exclude-from-legacy.md
.changeset/vpk1-fix-workflow-icon-400-gap.md
packages/design-data-spec/schemas/token.schema.json
packages/design-data/components/button.json
packages/design-data/components/combo-box.json
packages/design-data/components/number-field.json
packages/design-data/components/text-area.json
packages/design-data/components/text-field.json
packages/design-data/tokens/layout.tokens.json
sdk/core/src/legacy.rs

@github-actions

Copy link
Copy Markdown
Contributor

🧩 Component Schema Changes Report

Component Schemas Changed (0 added, 0 deleted, 5 updated)

Original Branch: main

New Branch: feat/button-corner-radius-exclude-from-legacy

✅ No Breaking Changes

This PR contains only non-breaking changes to component schemas.

🔄 Non-Breaking Updates

button

combo-box

number-field

text-area

text-field


This diff was generated automatically and contains only backward-compatible changes.


This comment was automatically generated by the component schema diff tool. 🤖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant