You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.
Reviewed the fix for scheduler path resolution in Sidekick edit mode (tools/scheduler/schedule.js, tools/scheduler/utils.js, tools/scheduler/README.md, tests/tools/scheduler/utils.test.js).
Summary
isPageHost/parseSidekickParams cleanly separates "referrer is the page itself" (.aem.page/.aem.live/.aem.reviews) from "referrer is an authoring surface" (SharePoint, Google Docs, custom prod domains), and the new isProject flag correctly gates when the pathname can be trusted directly.
resolvePagePath in schedule.js falls back to the Admin API's status endpoint with editUrl — the same mechanism Sidekick itself uses — only when path is empty and a referrer is present. The gating condition (!path && !isProject && org && site && referrer) is correct, and since path can only be non-empty when isProject is true, the checks are consistent (the !path check is redundant but harmless).
Error handling follows the existing { path/ok, error, resp } envelope pattern used elsewhere in the file (ensurePreview, writeIntent), and the missing-context message is correctly overridden with the specific resolution error when available.
New tests (isPageHost, parseSidekickParams) cover the pure branching logic per this repo's testing philosophy (TESTING.md) — the DOM/fetch orchestration in resolvePagePath is reasonably left untested since it isn't a shared-library contract.
README update accurately documents the new fallback behavior and its rationale.
I did not find any BLOCKING or SHOULD FIX issues. One thing worth a manual sanity check before merge (not a code issue, just unverifiable from static review): confirm the Admin status API response field is actually webPath for your account/site, since that's the crux of the fix — the PR description's "Before/After" preview links suggest this was already tested manually via Sidekick edit mode, which would confirm it.
Note: I was unable to execute npm run lint / npm test in this sandbox (tool execution was restricted), so please confirm CI is green via gh pr checks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: When using schedule sidekick plugin in edit mode, the path is incorrect.
Fix: We need to resolve the path using status api for that to get the right path to use for preview and publish.
Test URLs: