Skip to content

fix(feedback): stop 404s from loadArea icon decorator #595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hannessolo wants to merge 1 commit into
base: main
Choose a base branch
from
+12 −8
Open

fix(feedback): stop 404s from loadArea icon decorator #595

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions nx2/blocks/feedback/feedback.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
import { LitElement, html, nothing } from 'da-lit';
import { getConfig } from '../../scripts/nx.js';
import { loadStyle } from '../../utils/utils.js';
import { loadFragment } from '../fragment/fragment.js';
import '../shared/menu/menu.js';

const { codeBase } = getConfig();
Expand Down Expand Up @@ -92,9 +91,14 @@ class NxFeedback extends LitElement {
}

async _loadItems() {
const fragment = await loadFragment(FEEDBACK_PATH);
if (!fragment) return;
this._items = parseFeedbackItems(fragment);
// Parse directly, not via loadFragment: loadArea's icon decorator 404s
// on nonexistent S2_Icon_* SVGs, and we discard its DOM work anyway.
const resp = await fetch(FEEDBACK_PATH);
if (!resp.ok) return;
const doc = new DOMParser().parseFromString(await resp.text(), 'text/html');
const main = doc.querySelector('main');
if (!main) return;
this._items = parseFeedbackItems(main);
}

_handleSelect({ detail: { id } }) {
Expand Down
8 changes: 4 additions & 4 deletions nx2/test/unit/nx/blocks/feedback/feedback.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
import { expect } from '@esm-bundle/chai';
import { setConfig } from '../../../../../scripts/nx.js';

// fragment.js (a transitive dependency of feedback.js) captures getConfig()
// into a module-level constant at import time, so setConfig() must resolve
// before feedback.js is ever imported — a static import would evaluate (and
// freeze that constant) before this file's own top-level code could run.
// feedback.js captures getConfig() into a module-level constant at import
// time (for ICON_HREF), so setConfig() must resolve before feedback.js is
// ever imported — a static import would evaluate (and freeze that constant)
// before this file's own top-level code could run.
await setConfig({ hostnames: [] });
const { parseFeedbackItems } = await import('../../../../../blocks/feedback/feedback.js');

Expand Down
Loading