Skip to content

feat(ew): show loading spinner on preview & publish #592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
usman-khalid wants to merge 2 commits into
base: main
Choose a base branch
from
+31 −4
Open

feat(ew): show loading spinner on preview & publish #592

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ad5e303
feat(ew): show loading spinner on preview & publish
usman-khalid Jul 10, 2026
663ca0f
Merge branch 'main' into spin
usman-khalid Jul 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 26 additions & 0 deletions nx2/blocks/ew-actions/ew-actions.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,32 @@
height: 18px;
}

.preview-dropdown-btn.is-busy:disabled {
color: light-dark(var(--s2-gray-25), #fff);
background-color: var(--s2-blue-900);
}

.preview-dropdown-spinner {
display: block;
flex-shrink: 0;
width: 12px;
height: 12px;
border: 2px solid currentcolor;
border-top-color: transparent;
border-radius: 50%;
animation: preview-dropdown-spin 0.6s linear infinite;
}

@keyframes preview-dropdown-spin {
to { transform: rotate(360deg); }
}

@media (prefers-reduced-motion: reduce) {
.preview-dropdown-spinner {
animation-duration: 1.5s;
}
}

.preview-dropdown-label {
white-space: nowrap;
}
Expand Down
9 changes: 5 additions & 4 deletions nx2/blocks/ew-actions/ew-actions.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,8 +58,6 @@ class NXEwActions extends LitElement {
_dialog: { state: true },
};

_busy = false;

get _popover() {
return this.shadowRoot?.querySelector('nx-popover');
}
Expand All @@ -78,6 +76,7 @@ class NXEwActions extends LitElement {

connectedCallback() {
super.connectedCallback();
this._busy = false;
this.shadowRoot.adoptedStyleSheets = [style];
this._unsubHash = hashChange.subscribe((state) => { this._hashState = state; });
this._loadPrepare();
Expand Down Expand Up @@ -254,14 +253,16 @@ class NXEwActions extends LitElement {
` : nothing}
<button
type="button"
class="preview-dropdown-btn${this._hasError ? ' is-error' : ''}"
class="preview-dropdown-btn${this._hasError ? ' is-error' : ''}${this._busy ? ' is-busy' : ''}"
aria-label="Preview and publish"
aria-haspopup="menu"
aria-expanded="false"
?disabled=${disabled}
@click=${this._togglePreviewPopover}
>
<svg class="preview-dropdown-icon" viewBox="0 0 20 20" aria-hidden="true"><use href=${SEND_ICON_HREF}></use></svg>
${this._busy
? html`<span class="preview-dropdown-spinner" aria-hidden="true"></span>`
: html`<svg class="preview-dropdown-icon" viewBox="0 0 20 20" aria-hidden="true"><use href=${SEND_ICON_HREF}></use></svg>`}
</button>
<nx-popover placement="below" @close=${this._onSendPopoverClose}>
<div class="send-popover" role="menu">
Expand Down
Loading