Feat/secure org block nx2 migration#590
Open
hannessolo wants to merge 7 commits into
Open
Conversation
Add 'secure-org' to NX_BLOCKS and update imports in secure-org.js and utils.js to nx2 equivalents. Block stays in nx/ per migration convention. nx2's daFetch takes destructured args, so fetchConfig's call site is updated. Icon URLs built from import.meta.url since they live only in nx1's public/icons/. CSS variables in secure-org.css get nx2 names with nx1 fallback. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
mhaack
reviewed
Jul 9, 2026
Comment on lines
+11
to
+13
| new URL('../../public/icons/S2_Icon_InfoCircle_20_N.svg', import.meta.url).href, | ||
| new URL('../../public/icons/S2_Icon_AlertDiamond_20_N.svg', import.meta.url).href, | ||
| new URL('../../public/icons/S2_Icon_CheckmarkCircle_20_N.svg', import.meta.url).href, |
Contributor
There was a problem hiding this comment.
Should we change to new icon format?
…c load Address PR review from @mhaack. Same treatment as PR #588: - Drop the loadIcons import, the ICONS array, and the module-top-level fetch. Also drop the shadow-root prepend in connectedCallback. - renderAlert now references the CDN icon directly: <svg viewBox="0 0 20 20" aria-hidden="true"> <use href="/img/icons/s2-icon-${name}-20-n.svg#icon"/> </svg> - type2icon values change from CamelCase sprite IDs to lowercase-kebab filenames: 'infocircle', 'alertdiamond', 'checkmarkcircle'. - Drop the now-dead ':host > svg { display: none; }' rule that was hiding the previously-prepended sprites. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
aem-code-sync
Bot
temporarily deployed
to
feat/secure-org-block-nx2-migration
mhaack
previously approved these changes
Jul 10, 2026
Matches nx1 (nexter.css) and da-live browse — both force color-scheme: light regardless of system preference or profile toggle. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
aem-code-sync
Bot
temporarily deployed
to
feat/secure-org-block-nx2-migration
Add permissions and snapshot-admin to NX_BLOCKS alongside secure-org. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
aem-code-sync
Bot
temporarily deployed
to
feat/secure-org-block-nx2-migration
Reverts style(nx2): pin color scheme to light mode (9e74af2). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
mhaack
approved these changes
Jul 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #537
https://main--da-live--adobe.aem.live/apps/sandbox?nx=feat-secure-org-block-nx2-migration&nxver=2