Feat/bulk block nx2 migration#588
Open
hannessolo wants to merge 4 commits into
Open
Conversation
Add 'bulk' to NX_BLOCKS and update all imports in nx/blocks/bulk/ (bulk.js + index.js) to nx2 equivalents. Block stays in nx/ per migration convention. nx2's daFetch takes destructured args, so sendAction's call site is updated accordingly. CSS variables in bulk.css get nx2 names with nx1 fallback so the block renders correctly on both nx1 and nx2 pages. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
mhaack
reviewed
Jul 9, 2026
mhaack
reviewed
Jul 9, 2026
Address PR review from @mhaack: - Card/list backgrounds swapped from hardcoded rgb() to Spectrum tokens (--s2-green-200, --s2-cyan-200, --s2-cyan-300, --s2-red-300), which get automatic light/dark support via light-dark(). - .delete-toggle red pill uses --s2-red-700 and --s2-corner-radius-500. - Removed the block-scoped 'button { font-family }' rule — sl-button handles its own font, and the two custom buttons (.cancel-button, .toggle-list-icon) inherit from the block just fine. - Removed the input[name="label"] rule — dead code: the label field is rendered as <sl-input>, not <input>, so this selector never matched. sl-input styles itself. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
aem-code-sync
Bot
temporarily deployed
to
feat/bulk-block-nx2-migration
Drop the loadIcons import and module-top-level SVG fetch. Reference
the CDN icon directly:
<svg viewBox="0 0 20 20" aria-hidden="true">
<use href="/img/icons/s2-icon-chevronright-20-n.svg#icon"/>
</svg>
The s2-icon-*-20-n.svg files on da-live have id="icon" on the root
and use currentColor, matching the pattern used in nx2/blocks/chat.
Also drops the now-dead ':host > svg { display: none; }' rule that
was hiding the previously-prepended sprite.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
mhaack
approved these changes
Jul 10, 2026
hannessolo
added a commit
that referenced
this pull request
Jul 10, 2026
…c load Address PR review from @mhaack. Same treatment as PR #588: - Drop the loadIcons import, the ICONS array, and the module-top-level fetch. Also drop the shadow-root prepend in connectedCallback. - renderAlert now references the CDN icon directly: <svg viewBox="0 0 20 20" aria-hidden="true"> <use href="/img/icons/s2-icon-${name}-20-n.svg#icon"/> </svg> - type2icon values change from CamelCase sprite IDs to lowercase-kebab filenames: 'infocircle', 'alertdiamond', 'checkmarkcircle'. - Drop the now-dead ':host > svg { display: none; }' rule that was hiding the previously-prepended sprites. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #530
https://main--da-live--adobe.aem.live/apps/bulk?nx=feat-bulk-block-nx2-migration&nxver=2