feat(nx2): port sandbox org-check to nx2#586
Open
hannessolo wants to merge 5 commits into
Open
Conversation
Co-Authored-By: Claude <noreply@anthropic.com>
…ation Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Claude <noreply@anthropic.com>
mhaack
reviewed
Jul 9, 2026
mhaack
left a comment
mhaack
left a comment
Contributor
There was a problem hiding this comment.
Does the toast.js has some tests as well we should update or should we add some.
Comment on lines
+83
to
+85
| let variantClass = VARIANT_SUCCESS; | ||
| if (isError) variantClass = VARIANT_ERROR; | ||
| else if (isWarning) variantClass = VARIANT_WARNING; |
Contributor
There was a problem hiding this comment.
Only cosmetic but this could be ...
Suggested change
| let variantClass = VARIANT_SUCCESS; | |
| if (isError) variantClass = VARIANT_ERROR; | |
| else if (isWarning) variantClass = VARIANT_WARNING; | |
| const variantClass = isError ? VARIANT_ERROR : isWarning ? VARIANT_WARNING : VARIANT_SUCCESS; |
Address PR review from @mhaack. The exact suggested form 'isError ? VARIANT_ERROR : isWarning ? VARIANT_WARNING : VARIANT_SUCCESS' trips no-nested-ternary, so use the lint-clean equivalent 'isError || isWarning ? this.variant : VARIANT_SUCCESS' — same observable output, one expression instead of let + if/else. New test/nx2/blocks/shared/toast/toast.test.js (11 tests): - Host region and nx-toast are created and wired up - Empty / whitespace / missing text is a no-op - Text is trimmed - Default variant is success; role is 'status' - Error and warning variants get the right class and role='alert' - Unknown variant falls back to success - CTA link renders when { href, text } is provided; absent otherwise - Close button dismisses (removes the toast) - maxWidth is applied as the --nx-toast-max-width inline var Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
mhaack
approved these changes
Jul 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #539
https://da.live/#/da-sites/nexter