feat(ew): add support for blocks search in slash menu#1084
Open
usman-khalid wants to merge 2 commits into
Open
feat(ew): add support for blocks search in slash menu#1084usman-khalid wants to merge 2 commits into
usman-khalid wants to merge 2 commits into
Conversation
hannessolo
reviewed
Jul 10, 2026
| }); | ||
|
|
||
| addSyncedListener(wsProvider, canWrite, setEditable); | ||
| prefetchBlocksAfterSync(wsProvider, canWrite); |
Contributor
There was a problem hiding this comment.
I wonder if we could wait until the user types / to fetch this? Probably there would be enough time int he time it takes to type the block name?
Contributor
Author
There was a problem hiding this comment.
I thought about this - but IMO power users are pretty quick if they know what they want from the slash menu. Currently prefetches after the doc is loaded which should be fine? @mhaack thoughts?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support to slash menu to pick blocks from the library if configured.
Test URL: https://ewsta--da-live--adobe.aem.page/canvas?da-admin=stage&da-collab=stage#/usman-khalid/stage-site-2/comments
Should be merged with: adobe/da-nx#585