Skip to content

fix: ACNA-3430 - node@v22 punycode module deprecated - #84

Closed
shazron wants to merge 4 commits into
masterfrom
node-22-dep
Closed

fix: ACNA-3430 - node@v22 punycode module deprecated#84
shazron wants to merge 4 commits into
masterfrom
node-22-dep

Conversation

@shazron

@shazron shazron commented Jan 7, 2025

Copy link
Copy Markdown
Contributor

closes #83

Tested by local installing this branch with node@v22:

mkdir test
cd test
npm init -y
npm i path/to/branch/code/here
node -e "require('@adobe/aio-lib-core-networking')"

The punycode warning should not be printed out.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov

codecov Bot commented Jan 7, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@shazron

shazron commented Nov 13, 2025

Copy link
Copy Markdown
Contributor Author

Closing - use built in fetch instead.

@shazron shazron closed this Nov 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

node v22 - punycode module deprecated

4 participants