-
Notifications
You must be signed in to change notification settings - Fork 8
feat: add structured logging provider with field injection #65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
obarcelonap
wants to merge
4
commits into
adobe:master
Choose a base branch
from
obarcelonap:feat/structured-logging
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
8515046
feat: add structured logging provider with field injection
obarcelonap 57e9840
refactor: remove unnecessary util.format in WinstonStructuredLogger
obarcelonap cf473ed
refactor: extract buildEntry helper in WinstonStructuredLogger
obarcelonap 0a7ee82
docs: document buildEntry and fix copyright year in new files
obarcelonap File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,53 @@ | ||
| /* | ||
| Copyright 2026 Adobe. All rights reserved. | ||
| This file is licensed to you under the Apache License, Version 2.0 (the "License"); | ||
| you may not use this file except in compliance with the License. You may obtain a copy | ||
| of the License at http://www.apache.org/licenses/LICENSE-2.0 | ||
|
|
||
| Unless required by applicable law or agreed to in writing, software distributed under | ||
| the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR REPRESENTATIONS | ||
| OF ANY KIND, either express or implied. See the License for the specific language | ||
| governing permissions and limitations under the License. | ||
| */ | ||
| const winston = require('winston') | ||
| const getWinstonTransports = require('./winstonTransports') | ||
|
|
||
| /** | ||
| * Builds a structured log entry object from log method arguments and fields. | ||
| * Statement-level fields (second element of data) are merged over logger-level | ||
| * fields, so per-call values take precedence on key collision. | ||
| * | ||
| * @param {Array} data - arguments passed to a log method: [message, stmtFields?] | ||
| * @param {object} fields - logger-level fields set at construction time | ||
| * @returns {object} log entry ready to pass to winston | ||
| */ | ||
| function buildEntry (data, fields) { | ||
| const [message = '', stmtFields = {}] = data | ||
| return { message, ...fields, ...stmtFields } | ||
| } | ||
|
|
||
| class WinstonStructuredLogger { | ||
| constructor (config) { | ||
| this.fields = config.fields || {} | ||
| this.logger = winston.createLogger({ | ||
| level: config.level, | ||
| format: winston.format.combine( | ||
| winston.format.label({ label: config.label }), | ||
| winston.format.timestamp(), | ||
| winston.format.json() | ||
| ), | ||
| transports: getWinstonTransports(config.transports), | ||
| silent: config.silent | ||
| }) | ||
| } | ||
|
|
||
| close () { this.logger.close() } | ||
| error (...data) { this.logger.error(buildEntry(data, this.fields)) } | ||
| warn (...data) { this.logger.warn(buildEntry(data, this.fields)) } | ||
| info (...data) { this.logger.info(buildEntry(data, this.fields)) } | ||
| verbose (...data) { this.logger.verbose(buildEntry(data, this.fields)) } | ||
| debug (...data) { this.logger.debug(buildEntry(data, this.fields)) } | ||
| silly (...data) { this.logger.silly(buildEntry(data, this.fields)) } | ||
| } | ||
|
|
||
| module.exports = WinstonStructuredLogger |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,32 @@ | ||
| /* | ||
| Copyright 2026 Adobe. All rights reserved. | ||
| This file is licensed to you under the Apache License, Version 2.0 (the "License"); | ||
| you may not use this file except in compliance with the License. You may obtain a copy | ||
| of the License at http://www.apache.org/licenses/LICENSE-2.0 | ||
|
|
||
| Unless required by applicable law or agreed to in writing, software distributed under | ||
| the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR REPRESENTATIONS | ||
| OF ANY KIND, either express or implied. See the License for the specific language | ||
| governing permissions and limitations under the License. | ||
| */ | ||
| const winston = require('winston') | ||
| const DEFAULT_DEST = 'console' | ||
|
|
||
| function getWinstonTransports (transports = DEFAULT_DEST) { | ||
| const wTransports = [] | ||
| switch (transports) { | ||
| case 'console': | ||
| wTransports.push(new winston.transports.Console()) | ||
| break | ||
| default: | ||
| if (typeof (transports) === 'string' && transports.toString().indexOf('.') !== -1) { | ||
| wTransports.push(new winston.transports.File({ filename: transports })) | ||
| } else { | ||
| transports.forEach((t) => wTransports.push(t)) | ||
| } | ||
| break | ||
| } | ||
| return wTransports | ||
| } | ||
|
|
||
| module.exports = getWinstonTransports |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not a blocker, but maybe something like
jsonfits more for the provider name? Or similar.structuredalso sounds good but reads a bit weird to me.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No strong opinion, let's wait for the owners review.