CEXT-6498: publishEvent: uninstall does not clear stored event/provider data - #592
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: b6ea926 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
Bot
added
with-changeset
jcuerdo
commented
Jul 23, 2026
iivvaannxx
reviewed
Jul 23, 2026
iivvaannxx
left a comment
iivvaannxx
left a comment
Collaborator
There was a problem hiding this comment.
This would work, but I wonder if it's just not easier to delete the whole events system config on uninstall instead of per-provider.
obarcelonap
approved these changes
Jul 24, 2026
iivvaannxx
approved these changes
Jul 24, 2026
iivvaannxx
left a comment
iivvaannxx
left a comment
Collaborator
There was a problem hiding this comment.
Approving with nitpicks. Would be great if fixed, but not blockers
…github.com/adobe/aio-commerce-sdk into CEXT-6498/events-storage-uninstall-cleanup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
publishEvent (added in aio-commerce-sdk PR #561, package @adobe/aio-commerce-lib-app) resolves an event's I/O Events provider ID and event code by reading data written to system config storage under the key EVENTS_STORAGE_KEY (="events") at install time. This storage is never cleared or updated during uninstall, so a stale, already-deleted providerId can remain in storage and cause publishEvent to fail after uninstall.
Test
Tested with: https://development-271530-956ochrerattlesnake-cext6498.adobeioruntime.net/api/v1/web/my-package/emit-event
After install:
After uninstall:
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: