ArtifactOf pydantic integration + registry.extra reorg (0.6.0) - #12
Open
adnanhd wants to merge 5 commits into
Open
ArtifactOf pydantic integration + registry.extra reorg (0.6.0)#12adnanhd wants to merge 5 commits into
adnanhd wants to merge 5 commits into
Conversation
|
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ships v0.6.0: a pydantic-native
ArtifactOftype, a core/extra split for theobservability batteries, and a coverage pass.
Changes
ArtifactOf[Registry](registry.integrations.pydantic): a field or@validate_callargument that accepts a live artifact of the registry'selement type or a config to build, serializes mode-aware (python -> artifact,
json -> the
{type, data, meta}config), and accepts a union of registrars(
ArtifactOf[A, B]). Its validator threads already-validated siblings(
info.data) into the build scope, so a$sibling.attr()ref (e.g. anoptimizer over
$model.parameters()) resolves against the live sibling.Lifetime) and reporters (Journal/HTTPDashboard/OpenTelemetry) move to
registry.extra; the core keeps the attach/detach/emit buses.markers, the profiler meter) leaves the shipped package for
examples/._version,engines,utils, and the validator mixin.Breaking
registry.extra.meters/registry.extra.reporters(were top-level).registry.experimentalis gone;torch_compatlives inexamples/.Verification
pytest: full suite green except one pre-existing torch-profiler test(unrelated -- a renamed torch attribute on this Python build).