Fix wide JSON foreign tables returning NULL for most columns - #56
Open
roseduan wants to merge 1 commit into
Open
Fix wide JSON foreign tables returning NULL for most columns#56roseduan wants to merge 1 commit into
roseduan wants to merge 1 commit into
Conversation
getJsonAttname() returned an interior pointer into the shared, growable attname_buf StringInfo. With many/long JSON keys the buffer is repalloc'd and relocated, leaving the pointers already stored in attnames[] dangling, so all but the last few columns silently decode to NULL. Return a pstrdup'd copy of each key instead, and drop the now-unused attname_buf field and StringInfo parameter.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
getJsonAttname() returned an interior pointer into the shared, growable attname_buf StringInfo. With many/long JSON keys the buffer is repalloc'd and relocated, leaving the pointers already stored in attnames[] dangling, so all but the last few columns silently decode to NULL.
Return a pstrdup'd copy of each key instead, and drop the now-unused attname_buf field and StringInfo parameter.