Use builtins.filterSource instead of fileset API for local package sources - #5
Merged
Conversation
Contributor
|
any update on this? :) |
Owner
Author
|
@ethancedwards8 I was awaiting feedback from someone on this work before merging. But in the mean time NixOS/nixpkgs#462272 was merged so I've rebuilt this on top of Please try it out and see if it works for you. |
Contributor
|
Ran into needing NixOS/nixpkgs#538314 on our stable branch during testing. |
Owner
Author
|
Backport in the nixpkgs merge queue :) |
Signed-off-by: Ethan Carter Edwards <ethan@ethancedwards.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fileset library is quite slow & allocates a lot of memory.
On a test module with 47 packages in a private repository these are the performance numbers observed:
after{ "cpuTime": 0.8548020124435425, "envs": { "bytes": 30595216, "elements": 2160513, "number": 1663889 }, "gc": { "cycles": 1, "heapSize": 402915328, "totalBytes": 154765680 }, "list": { "bytes": 3707256, "concats": 70997, "elements": 463407 }, "nrAvoided": 1766805, "nrExprs": 792722, "nrFunctionCalls": 1581789, "nrLookups": 637093, "nrOpUpdateValuesCopied": 2343330, "nrOpUpdates": 179146, "nrPrimOpCalls": 750587, "nrThunks": 1788793, "sets": { "bytes": 57132440, "elements": 3308087, "number": 175127 }, "sizes": { "Attr": 16, "Bindings": 24, "Env": 8, "Value": 16 }, "symbols": { "bytes": 707113, "number": 62302 }, "time": { "cpu": 0.8548020124435425, "gc": 0.01, "gcFraction": 0.011698615415532231 }, "values": { "bytes": 38270000, "number": 2391875 } }before{ "cpuTime": 0.939765989780426, "envs": { "bytes": 33301400, "elements": 2333111, "number": 1829564 }, "gc": { "cycles": 1, "heapSize": 402915328, "totalBytes": 164830608 }, "list": { "bytes": 4190464, "concats": 74006, "elements": 523808 }, "nrAvoided": 2023460, "nrExprs": 792635, "nrFunctionCalls": 1728192, "nrLookups": 663377, "nrOpUpdateValuesCopied": 2343786, "nrOpUpdates": 179434, "nrPrimOpCalls": 902783, "nrThunks": 1929008, "sets": { "bytes": 57700800, "elements": 3334788, "number": 181008 }, "sizes": { "Attr": 16, "Bindings": 24, "Env": 8, "Value": 16 }, "symbols": { "bytes": 707099, "number": 62300 }, "time": { "cpu": 0.939765989780426, "gc": 0.011, "gcFraction": 0.011705041595057215 }, "values": { "bytes": 41625136, "number": 2601571 } }